Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gui-client): use new download links #4754

Merged
merged 19 commits into from
Apr 29, 2024

Conversation

ReactorScram
Copy link
Collaborator

@ReactorScram ReactorScram commented Apr 23, 2024

ae67064 works on the live site.

However if you click the notification while the tunnel is coming up, there's a chance that the download will fail because Firezone isn't fully up yet. Oops. That will probably only affect us since we have github.com as a resource. If real customers are okay with their Firezone updates coming through normal Internet it'll probably be fine.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 9:46pm

…ew-download-links

Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
@github-actions github-actions bot added the kind/chore Issues related to repository cleanup or maintenance label Apr 23, 2024
Copy link

github-actions bot commented Apr 23, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 14 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Apr 23, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 239.7 MiB (+3%) 241.5 MiB (+3%) 217 (-11%)
direct-tcp-server2client 241.8 MiB (+3%) 243.7 MiB (+3%) 214 (-30%)
relayed-tcp-client2server 225.1 MiB (-2%) 226.1 MiB (-2%) 285 (+22%)
relayed-tcp-server2client 242.3 MiB (+2%) 242.9 MiB (+2%) 507 (+8%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (-0%) 0.06ms (+57%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.01ms (-8%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.06ms (+138%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (-0%) 0.01ms (-35%) 0.00% (NaN%)

Base automatically changed from refactor/change-windows-artifact-name to main April 24, 2024 16:42
@ReactorScram ReactorScram marked this pull request as ready for review April 24, 2024 23:28
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this ready for review? Changes LGTM

@ReactorScram ReactorScram added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
@ReactorScram ReactorScram added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 28423e9 Apr 29, 2024
134 checks passed
@ReactorScram ReactorScram deleted the chore/use-new-download-links branch April 29, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Issues related to repository cleanup or maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants