-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gui-client): use new download links #4754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rezone/firezone into refactor/change-windows-artifact-name
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…ew-download-links Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
github-actions
bot
added
the
kind/chore
Issues related to repository cleanup or maintenance
label
Apr 23, 2024
Terraform Cloud Plan Output
|
…to chore/use-new-download-links
Performance Test ResultsTCP
UDP
|
jamilbk
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this ready for review? Changes LGTM
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ae67064 works on the live site.
However if you click the notification while the tunnel is coming up, there's a chance that the download will fail because Firezone isn't fully up yet. Oops. That will probably only affect us since we have github.com as a resource. If real customers are okay with their Firezone updates coming through normal Internet it'll probably be fine.