fix(windows-client): allow sign out while connlib is raising the tunnel #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I simulated a wintun error like the one that causes #4765, and the message is correct - It's not that Tauri did something impossible, it's that there's a window between `Session::connect` and the tunnel being ready where we don't have a useful way to cancel the sign-in
ReactorScram
added
kind/bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
|
@ReactorScram sorry -- will need to remove from queue and rebase because #4746 changed the test names :-( |
|
Once that ones in I can update this PR and re-add it. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4763
Previously it would get stuck signing in and say that the situation was impossible, it was actually possible.
I tested this manually by forcing the tunnel to error out in the place where wintun fails for #4765