Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bootstrap browser test harness if missing #4767

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Apr 24, 2024

Should be a less brittle fix to the problem of testing release images for compat-tests with the browser harness.

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 4:47pm

@@ -88,7 +98,7 @@ function create_token_file {
sudo mkdir "$CONFIG_DIR"
sudo touch "$TOKEN_PATH"
sudo chmod 600 "$TOKEN_PATH"
echo "n.SFMyNTY.g2gDaANtAAAAJGM4OWJjYzhjLTkzOTItNGRhZS1hNDBkLTg4OGFlZjZkMjhlMG0AAAAkN2RhN2QxY2QtMTExYy00NGE3LWI1YWMtNDAyN2I5ZDIzMGU1bQAAACtBaUl5XzZwQmstV0xlUkFQenprQ0ZYTnFJWktXQnMyRGR3XzJ2Z0lRdkZnbgYAGUmu74wBYgABUYA.UN3vSLLcAMkHeEh5VHumPOutkuue8JA6wlxM9JxJEPE" | sudo tee "$TOKEN_PATH" > /dev/null
echo "n.SFMyNTY.g2gDaANtAAAAJGM4OWJjYzhjLTkzOTItNGRhZS1hNDBkLTg4OGFlZjZkMjhlMG0AAAAkN2RhN2QxY2QtMTExYy00NGE3LWI1YWMtNDAyN2I5ZDIzMGU1bQAAACtBaUl5XzZwQmstV0xlUkFQenprQ0ZYTnFJWktXQnMyRGR3XzJ2Z0lRdkZnbgYAGUmu74wBYgABUYA.UN3vSLLcAMkHeEh5VHumPOutkuue8JA6wlxM9JxJEPE" | sudo tee "$TOKEN_PATH" >/dev/null
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shfmt likes to remove the for redirection

Copy link

github-actions bot commented Apr 24, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 15 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Apr 24, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 238.6 MiB (-1%) 240.1 MiB (-1%) 391 (+33%)
direct-tcp-server2client 243.7 MiB (+2%) 245.1 MiB (+2%) 132 (-62%)
relayed-tcp-client2server 224.2 MiB (-1%) 225.5 MiB (-1%) 340 (+30%)
relayed-tcp-server2client 231.7 MiB (-0%) 232.5 MiB (-0%) 511 (+39%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.04ms (+13%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (-0%) 0.03ms (+271%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (+0%) 0.08ms (+102%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.03ms (+121%) 0.00% (NaN%)

Copy link
Collaborator

@ReactorScram ReactorScram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it fixes the compat tests 📈

@jamilbk jamilbk enabled auto-merge April 24, 2024 16:46
@jamilbk jamilbk added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit 0b83b12 Apr 24, 2024
133 checks passed
@jamilbk jamilbk deleted the fix/compat-browser-tests branch April 24, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants