ci: use consistent binary dest path naming #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
|
Waiting to see what the CI output looks like |
ReactorScram
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Something went off here https://github.com/firezone/firezone/actions/runs/8822073323/job/24219388108#step:11:23
Performance Test ResultsTCP
UDP
|
|
CI is green now 🤞 |
ReactorScram
approved these changes
Apr 24, 2024
Comment on lines
-10
to
-12
| cp ../target/release/firezone "$BINARY_DEST_PATH"-amd64 | ||
| cp ../target/release/firezone-gui-client.dwp "$BINARY_DEST_PATH"-amd64.dwp | ||
| cp ../target/release/bundle/deb/*_amd64.deb "$BINARY_DEST_PATH"_amd64.deb |
There was a problem hiding this comment.
I think the deb having an underscore where the other ones had a hyphen was just a convention, and Debian won't actually care if we break that, so this should be okay.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.