fix(headless-client): clean up and exit gracefully when on_disconnect called

[ReactorScram]

Calling std::process::exit won't let the DNS deactivation code runs. For some control methods (systemd-resolved) this doesn't matter. For etc-resolvconf and Windows, we are responsible for cleaning up DNS.

Tasks

Edit tasklist title

Beta Give feedback Tasklist Tasks, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Replicate the issue

   Replicate the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Fix it

   Fix it
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Remove the fault injection code

   Remove the fault injection code
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Tasks

Closes #4784

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
firezone	⬜️ Ignored (Inspect)	Visit Preview		Apr 25, 2024 10:34pm

[github-actions]

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 36 to destroy.

Terraform Cloud Plan

[github-actions]

Performance Test Results

TCP

Test Name	Received/s	Sent/s	Retransmits
direct-tcp-client2server	242.9 MiB (-1%)	245.4 MiB (-1%)	544 (+79%)
direct-tcp-server2client	240.5 MiB (+0%)	241.9 MiB (+0%)	375 (+50%)
relayed-tcp-client2server	224.2 MiB (-2%)	224.9 MiB (-2%)	239 (-21%)
relayed-tcp-server2client	236.6 MiB (-0%)	237.4 MiB (-0%)	332 (-26%)

UDP

Test Name	Total/s	Jitter	Lost
direct-udp-client2server	50.0 MiB (+0%)	0.08ms (+93%)	0.00% (NaN%)
direct-udp-server2client	50.0 MiB (-0%)	0.01ms (-26%)	0.00% (NaN%)
relayed-udp-client2server	50.0 MiB (+0%)	0.09ms (+48%)	0.00% (NaN%)
relayed-udp-server2client	50.0 MiB (+0%)	0.01ms (-30%)	0.00% (NaN%)

[thomaseizinger]

Whilst this may fix the DNS control thing, I think the PR title + description (which will be the commit message when merged) should talk about graceful clean-up or something similar.

Why this fixes DNS control settings is actually pretty incidential due to the way how we do this at the moment (on drop) which IMO is worth calling out.

[thomaseizinger]

Thanks!

I think we may also be able to get rid of the reference to the error? That API is very old and I think we now always have ownership over the error that we pass here.