Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gui-client): enable keyring for Linux #4799

Merged
merged 18 commits into from
Apr 26, 2024
Merged

chore(gui-client): enable keyring for Linux #4799

merged 18 commits into from
Apr 26, 2024

Conversation

ReactorScram
Copy link
Collaborator

Tasks

Edit tasklist title
Beta Give feedback Tasklist Tasks, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Maybe change that "dev.firezone.client/token" name to something friendlier
    Options

image

But it does work, survives reboots as expected, etc.
I can't test it easily in CI, I just disabled the keyring test for now. It works manually, and the keyring-rs crate seems pretty stable, and our use of it hasn't changed in a couple months at least.

@ReactorScram ReactorScram added area/linux_client Linux client area/tauri_client The Windows and Linux Tauri GUI clients labels Apr 26, 2024
@ReactorScram ReactorScram self-assigned this Apr 26, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 7:40pm

@github-actions github-actions bot added the kind/chore Issues related to repository cleanup or maintenance label Apr 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited

Terraform Cloud Plan Output

Plan: 15 to add, 14 to change, 15 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 26, 2024 •
edited

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 234.3 MiB (-2%) 235.5 MiB (-3%) 184 (-54%)
direct-tcp-server2client 243.9 MiB (+1%) 245.4 MiB (+1%) 342 (+217%)
relayed-tcp-client2server 222.0 MiB (-1%) 222.9 MiB (-1%) 243 (+4%)
relayed-tcp-server2client 236.2 MiB (+1%) 236.7 MiB (+1%) 405 (+4%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 50.0 MiB (+0%) 0.07ms (+71%) 0.00% (NaN%)
direct-udp-server2client 50.0 MiB (+0%) 0.01ms (-35%) 0.00% (NaN%)
relayed-udp-client2server 50.0 MiB (-0%) 0.05ms (-30%) 0.00% (NaN%)
relayed-udp-server2client 50.0 MiB (+0%) 0.01ms (-10%) 0.00% (NaN%)

@ReactorScram ReactorScram marked this pull request as ready for review April 26, 2024 20:03
jamilbk
jamilbk approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from chore/process-split-poc to main April 26, 2024 20:11
@ReactorScram ReactorScram added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 0e4ec7e Apr 26, 2024
134 checks passed
@ReactorScram ReactorScram deleted the chore/enable-linux-keyring branch April 26, 2024 20:27
@ReactorScram ReactorScram mentioned this pull request Apr 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

Assignees

@ReactorScram ReactorScram

Labels
area/linux_client Linux client area/tauri_client The Windows and Linux Tauri GUI clients kind/chore Issues related to repository cleanup or maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ReactorScram @jamilbk