chore(gui-client/linux): fix DNS #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
kind/chore
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
ReactorScram
commented
Apr 26, 2024
| pub fn get() -> Result<Vec<IpAddr>> { | ||
| tracing::error!("Resolvers module not yet implemented for Linux, returning empty Vec"); | ||
| Ok(Vec::default()) | ||
| firezone_headless_client::imp::get_system_default_resolvers_systemd_resolved() |
There was a problem hiding this comment.
I think all desktop systems we support will have systemd and probably systemd-resolved, so I made this the only option here for when the GUI retrieves the system resolvers
There was a problem hiding this comment.
Yep! Makes sense. "Install systemd-resolved" is a valid requirement I think.
jamilbk
approved these changes
Apr 26, 2024
| pub fn get() -> Result<Vec<IpAddr>> { | ||
| tracing::error!("Resolvers module not yet implemented for Linux, returning empty Vec"); | ||
| Ok(Vec::default()) | ||
| firezone_headless_client::imp::get_system_default_resolvers_systemd_resolved() |
There was a problem hiding this comment.
Yep! Makes sense. "Install systemd-resolved" is a valid requirement I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the GUI use systemd-resolved to retrieve the system's resolvers. This allows the IPC service to set up sentinels for those resolvers and control the system's DNS.
Closes #3812