Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gui-client/linux): fix notifications #4803

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore(gui-client/linux): fix notifications #4803

merged 1 commit into from
Apr 29, 2024

Conversation

ReactorScram
Copy link
Collaborator

The clickable "Firezone 1.x is ready to download" notification still isn't there. Tauri doesn't seem to have cross-platform clickable notifications.

@ReactorScram
chore(gui-client/linux): fix notifications
41cd01f 
The clickable "Firezone 1.x is ready to download" notification still
isn't there. Tauri doesn't seem to have cross-platform clickable notifications.
@ReactorScram ReactorScram added area/linux_client Linux client area/tauri_client The Windows and Linux Tauri GUI clients labels Apr 26, 2024
@ReactorScram ReactorScram self-assigned this Apr 26, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
firezone ⬜️ Ignored (Inspect) Apr 26, 2024 10:38pm

@github-actions github-actions bot added the kind/chore Issues related to repository cleanup or maintenance label Apr 26, 2024
@github-actions GitHub Actions
Copy link

Terraform Cloud Plan Output

Plan: 37 to add, 14 to change, 16 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 239.7 MiB (-0%) 242.0 MiB (+0%) 298 (+19%)
direct-tcp-server2client 245.3 MiB (+0%) 246.5 MiB (+0%) 208 (-54%)
relayed-tcp-client2server 227.1 MiB (-1%) 227.8 MiB (-1%) 328 (+55%)
relayed-tcp-server2client 239.4 MiB (-1%) 240.2 MiB (-0%) 426 (+27%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.06ms (-41%) 39.04% (-17%)
direct-udp-server2client 500.0 MiB (-0%) 0.01ms (-7%) 21.13% (-3%)
relayed-udp-client2server 500.0 MiB (+0%) 0.02ms (-45%) 55.32% (-4%)
relayed-udp-server2client 500.0 MiB (+0%) 0.02ms (-31%) 43.22% (+13%)

@ReactorScram ReactorScram marked this pull request as ready for review April 26, 2024 23:10
jamilbk
jamilbk approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booo Tauri.

This likely isn't a huge deal -- what happens if you add a link? Does it get parsed as a clickable link inside the notification message?

@ReactorScram ReactorScram added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
@ReactorScram ReactorScram added this pull request to the merge queue Apr 29, 2024
@ReactorScram
Copy link
Collaborator Author

Nah, I tried putting [Example](https://example.com) and it just showed that as plain text, no markdown, no auto linking

Merged via the queue into main with commit 9cf72f2 Apr 29, 2024
134 checks passed
@ReactorScram ReactorScram deleted the chore/linux-notifications branch April 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

Assignees

@ReactorScram ReactorScram

Labels
area/linux_client Linux client area/tauri_client The Windows and Linux Tauri GUI clients kind/chore Issues related to repository cleanup or maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ReactorScram @jamilbk