Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows-client): package name should be "Firezone" not "firezone-client-gui" #4814

Merged
merged 3 commits into from
Apr 29, 2024
Merged

fix(windows-client): package name should be "Firezone" not "firezone-client-gui" #4814

merged 3 commits into from
Apr 29, 2024

Conversation

ReactorScram
Copy link
Collaborator

@ReactorScram ReactorScram commented Apr 29, 2024 •
edited

Closes #4813

After PR, the installer, UAC dialog, and notifications all say "Firezone" again

image

@ReactorScram ReactorScram self-assigned this Apr 29, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 5:00pm

@github-actions github-actions bot added the kind/bug Something isn't working label Apr 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 29, 2024 •
edited

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 240.8 MiB (-3%) 242.5 MiB (-3%) 532 (+94%)
direct-tcp-server2client 242.8 MiB (+2%) 244.3 MiB (+2%) 233 (-33%)
relayed-tcp-client2server 221.6 MiB (-3%) 222.4 MiB (-3%) 247 (-11%)
relayed-tcp-server2client 239.2 MiB (+4%) 239.7 MiB (+4%) 380 (-15%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.02ms (-61%) 42.07% (+8%)
direct-udp-server2client 500.0 MiB (-0%) 0.01ms (-93%) 21.77% (-1%)
relayed-udp-client2server 500.0 MiB (-0%) 0.09ms (+63%) 56.66% (-1%)
relayed-udp-server2client 500.0 MiB (-0%) 0.04ms (-41%) 42.08% (-8%)

@ReactorScram ReactorScram marked this pull request as ready for review April 29, 2024 17:18
@ReactorScram ReactorScram added this to the 04/24 milestone Apr 29, 2024
jamilbk
jamilbk approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReactorScram ReactorScram added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit d0155bc Apr 29, 2024
134 checks passed
@ReactorScram ReactorScram deleted the fix/windows-package-name branch April 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

Assignees

@ReactorScram ReactorScram

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
05/24
Development

Successfully merging this pull request may close these issues.

bug(windows GUI): Everything that should say "Firezone" says "firezone-client-gui"
2 participants
@ReactorScram @jamilbk