chore(gui-client/linux): show an error if the user doesn't belong to the firezone group
#4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
kind/chore
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
ReactorScram
commented
Apr 30, 2024
| # Does what it says | ||
| sudo --preserve-env \ | ||
| su --login "$USER" --command \ | ||
| "xvfb-run --auto-servernum $PWD/../target/debug/$PACKAGE $*" |
There was a problem hiding this comment.
I don't quite understand why su needs the quotes here when it doesn't need them in other places. I guess its parsing must be naive and the double hyphens confuse it. It doesn't have the equivalent of Cargo's -- to delineate arguments intended for the subcommand.
Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
conectado
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this during testing. For some reason Ubuntu 20.04, maybe others, requires a reboot to add the desktop user to a group. I thought logging out and back in should be enough but it's not.