Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gui-client): cleanup #4836

Merged
merged 2 commits into from
May 1, 2024
Merged

chore(gui-client): cleanup #4836

merged 2 commits into from
May 1, 2024

Conversation

ReactorScram
Copy link
Collaborator

I noticed a few things were unused or incorrect, this fixes those

@ReactorScram
chore(gui-client): cleanup
14d28a1 
I noticed a few things were unused or incorrect, this fixes those
@ReactorScram ReactorScram self-assigned this Apr 30, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 3:22pm

@github-actions github-actions bot added the kind/chore Issues related to repository cleanup or maintenance label Apr 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 243.4 MiB (+2%) 245.2 MiB (+2%) 204 (-38%)
direct-tcp-server2client 242.2 MiB (+1%) 243.6 MiB (+1%) 430 (+42%)
relayed-tcp-client2server 224.8 MiB (+0%) 225.7 MiB (+0%) 239 (-15%)
relayed-tcp-server2client 237.1 MiB (+1%) 237.7 MiB (+1%) 314 (+17%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.05ms (+56%) 39.74% (-5%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (-78%) 20.95% (-7%)
relayed-udp-client2server 500.0 MiB (-0%) 0.09ms (+172%) 51.61% (-5%)
relayed-udp-server2client 500.0 MiB (+0%) 0.02ms (-62%) 42.16% (+3%)

@ReactorScram ReactorScram marked this pull request as ready for review April 30, 2024 21:46
@ReactorScram ReactorScram added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit 2721df2 May 1, 2024
137 checks passed
@ReactorScram ReactorScram deleted the chore/gui-client-cleanup branch May 1, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

Assignees

@ReactorScram ReactorScram

Labels
kind/chore Issues related to repository cleanup or maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ReactorScram @jamilbk