Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connlib): remove ice candidate on invalidate candidate message #4837

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(connlib): remove ice candidate on invalidate candidate message #4837

merged 1 commit into from
Apr 30, 2024

Conversation

conectado
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
firezone ⬜️ Ignored (Inspect) Apr 30, 2024 7:53pm

@github-actions github-actions bot added the kind/bug Something isn't working label Apr 30, 2024
@github-actions GitHub Actions
Copy link

Terraform Cloud Plan Output

Plan: 20 to add, 16 to change, 33 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 241.1 MiB (+0%) 243.1 MiB (+0%) 324 (+17%)
direct-tcp-server2client 244.6 MiB (+2%) 246.5 MiB (+2%) 280 (-47%)
relayed-tcp-client2server 228.9 MiB (+3%) 229.9 MiB (+4%) 208 (-32%)
relayed-tcp-server2client 239.7 MiB (+1%) 240.3 MiB (+1%) 392 (-2%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.05ms (+54%) 35.88% (-13%)
direct-udp-server2client 500.0 MiB (-0%) 0.02ms (+45%) 21.58% (-6%)
relayed-udp-client2server 500.0 MiB (-0%) 0.03ms (+12%) 53.07% (-7%)
relayed-udp-server2client 500.0 MiB (+0%) 0.01ms (-57%) 41.27% (+4%)

@jamilbk jamilbk added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@jamilbk jamilbk added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 52f1f84 Apr 30, 2024
136 checks passed
@jamilbk jamilbk deleted the fix/remove-ice-candidate-on-discard-connection branch April 30, 2024 22:54
@thomaseizinger
Copy link
Member

Wow, what a silly mistake. Should leverage the type-system more for these things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

@thomaseizinger thomaseizinger Awaiting requested review from thomaseizinger

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@conectado @thomaseizinger @jamilbk