Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run clippy for all targets #4871

Closed
wants to merge 11 commits into from
Closed

ci: Run clippy for all targets #4871

wants to merge 11 commits into from

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented May 1, 2024

#4869 (review)

Since linting well can often prevent bugs, I think it's worth the effort / complexity to ensure all of our code paths are linted with clippy.

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 1, 2024 8:04pm

Copy link

github-actions bot commented May 1, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented May 1, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 239.8 MiB (-1%) 241.1 MiB (-1%) 197 (+35%)
direct-tcp-server2client 241.6 MiB (-0%) 243.0 MiB (-0%) 335 (+245%)
relayed-tcp-client2server 226.4 MiB (+0%) 227.3 MiB (+1%) 244 (+7%)
relayed-tcp-server2client 237.2 MiB (-0%) 237.9 MiB (-0%) 538 (+61%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.03ms (-16%) 41.76% (-2%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (-12%) 22.13% (-2%)
relayed-udp-client2server 500.0 MiB (+0%) 0.04ms (-14%) 56.29% (+4%)
relayed-udp-server2client 500.0 MiB (+0%) 0.02ms (+32%) 38.93% (-13%)

@jamilbk
Copy link
Member Author

jamilbk commented May 1, 2024

@ReactorScram Yeah this is just looking more and more hairy. Giving up 🤷 -- maybe we can revisit in the future

@jamilbk jamilbk closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant