chore(gui-client/linux): add install script and change group to firezone-client
#4879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
kind/chore
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
ReactorScram
commented
May 2, 2024
| @@ -44,7 +44,7 @@ ExecStart=firezone-client-ipc | |||
| Type=notify | |||
| # Unfortunately we may need root to control DNS | |||
| User=root | |||
| Group=firezone | |||
| Group=firezone-client | |||
There was a problem hiding this comment.
Just in case we need it to be separate from the gateway group
jamilbk
approved these changes
May 2, 2024
Comment on lines
+23
to
+24
| # Unfortunately Ubuntu seems to need a reboot here, at least 20.04 does | ||
| echo "Reboot to finish adding yourself to the group" |
There was a problem hiding this comment.
Don't we just need to restart the current login session? I.e. logout and back in?
There was a problem hiding this comment.
I tried on 20.04, but it doesn't seem to work. Maybe it's something particular Ubuntu does, I know it used to work on other distros in the past.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4873