Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gui-client): move known_dirs module into headless-client #4908

Merged
merged 2 commits into from
May 8, 2024
Merged

refactor(gui-client): move known_dirs module into headless-client #4908

merged 2 commits into from
May 8, 2024

Conversation

ReactorScram
Copy link
Collaborator

@ReactorScram ReactorScram commented May 7, 2024 •
edited

This should make it easier for the IPC services on both Linux and Windows to write logs to well-known dirs that the GUI can read for exporting zips.

@ReactorScram
refactor(gui-client): move known_dirs module into headless-client
618c941 
I'm going to want a well-known dir that the Windows IPC service writes logs to,
and that the Windows GUI can pick them up from.

I don't know how I did this for Linux last week, but it should probably be in
here too.
@ReactorScram ReactorScram added the area/tauri_client The Windows and Linux Tauri GUI clients label May 7, 2024
@ReactorScram ReactorScram self-assigned this May 7, 2024
@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 11:27pm

@github-actions github-actions bot added the kind/refactor Code refactoring label May 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

@ReactorScram ReactorScram marked this pull request as ready for review May 7, 2024 23:30
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 243.8 MiB (+1%) 245.6 MiB (+1%) 432 (+84%)
direct-tcp-server2client 244.4 MiB (+1%) 246.3 MiB (+1%) 34 (-69%)
relayed-tcp-client2server 222.9 MiB (-2%) 224.0 MiB (-2%) 276 (+60%)
relayed-tcp-server2client 236.5 MiB (-2%) 237.0 MiB (-2%) 419 (+6%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.02ms (-39%) 44.54% (+5%)
direct-udp-server2client 500.0 MiB (+0%) 0.02ms (-2%) 22.59% (+9%)
relayed-udp-client2server 500.0 MiB (+0%) 0.02ms (-50%) 52.81% (-6%)
relayed-udp-server2client 500.0 MiB (+0%) 0.02ms (-47%) 45.23% (+8%)

@ReactorScram ReactorScram requested a review from jamilbk May 8, 2024 20:14
jamilbk
jamilbk approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@ReactorScram ReactorScram added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit da85408 May 8, 2024
135 checks passed
@ReactorScram ReactorScram deleted the refactor/move-known-dirs branch May 8, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

@conectado conectado Awaiting requested review from conectado

Assignees

@ReactorScram ReactorScram

Labels
area/tauri_client The Windows and Linux Tauri GUI clients kind/refactor Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ReactorScram @jamilbk