refactor(ci): use the same test framework for headless client and IPC service #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactorScram
added
area/ci
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
ReactorScram
commented
May 9, 2024
scripts/build/tauri-rename-ubuntu.sh
Outdated
There was a problem hiding this comment.
I was originally going to merge the linux-group test into this, and I left the refactoring of this file.
ReactorScram
commented
May 9, 2024
ReactorScram
commented
May 9, 2024
Performance Test ResultsTCP
UDP
|
kutsav
approved these changes
May 10, 2024
jamilbk
approved these changes
May 10, 2024
| @@ -11,32 +11,32 @@ SERVICE_NAME=firezone-client-ipc | |||
| SOCKET=/run/dev.firezone.client/ipc.sock | |||
| export RUST_LOG=info | |||
|
|
|||
| cd rust || exit 1 | |||
There was a problem hiding this comment.
Just curious why the explicit exit 1 here and not set -e at the top?
There was a problem hiding this comment.
The shellcheck pre-commit lint doesn't seem to be aware of lib.sh, so it actually doesn't know we're using set -euox pipefail at all. If I remove this, it errors and won't let me commit.
There was a problem hiding this comment.
Hopefully that doesn't cause shellcheck to report any false negatives anywhere else 😨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix an issue with
linux-groupandtoken-paththat happens when I try to split up the binaries.Before merging