Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): Reduce button sizes in live_table to xs #4945

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented May 10, 2024

  • Updates buttons in tables to size xs so they are a bit easier on the eyes and fixes Fix "Send Welcome Email" button layout #4938
  • Makes "Save" button placement consistent
  • Reduces count of Actors list in Edit actors for group page because it pushes the Save button below the fold and it was confusing some users because it wasn't obvious they needed to save the selection.

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 5:41am

@jamilbk jamilbk requested review from bmanifold and AndrewDryga and removed request for bmanifold May 10, 2024 04:54
@github-actions github-actions bot added the kind/bug Something isn't working label May 10, 2024
Copy link

github-actions bot commented May 10, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented May 10, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 240.1 MiB (-1%) 241.8 MiB (-1%) 412 (-17%)
direct-tcp-server2client 241.1 MiB (-1%) 242.5 MiB (-1%) 171 (+74%)
relayed-tcp-client2server 224.9 MiB (+0%) 225.4 MiB (+0%) 266 (-8%)
relayed-tcp-server2client 232.9 MiB (-4%) 233.5 MiB (-4%) 429 (+24%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.02ms (-75%) 41.35% (-7%)
direct-udp-server2client 500.0 MiB (-0%) 0.08ms (+700%) 21.97% (-4%)
relayed-udp-client2server 500.0 MiB (+0%) 0.00ms (-89%) 55.95% (-1%)
relayed-udp-server2client 499.9 MiB (-0%) 0.04ms (+58%) 46.06% (+4%)

@jamilbk jamilbk requested a review from bmanifold May 10, 2024 05:14

def delete_button(assigns) do
~H"""
<.button style="danger" icon="hero-trash-solid" {@rest}>
<.button style="danger" size={@size} con="hero-trash-solid" {@rest}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you accidentally deleted the i from the icon attribute

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@jamilbk jamilbk requested a review from bmanifold May 10, 2024 05:40
Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamilbk jamilbk enabled auto-merge May 10, 2024 05:50
@jamilbk jamilbk added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@jamilbk jamilbk added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 1536b12 May 10, 2024
135 checks passed
@jamilbk jamilbk deleted the fix/welcome-button branch May 10, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "Send Welcome Email" button layout
2 participants