-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(portal): Reduce button sizes in live_table to xs #4945
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output
|
Performance Test ResultsTCP
UDP
|
|
||
def delete_button(assigns) do | ||
~H""" | ||
<.button style="danger" icon="hero-trash-solid" {@rest}> | ||
<.button style="danger" size={@size} con="hero-trash-solid" {@rest}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you accidentally deleted the i
from the icon
attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xs
so they are a bit easier on the eyes and fixes Fix "Send Welcome Email" button layout #4938Edit actors
for group page because it pushes theSave
button below the fold and it was confusing some users because it wasn't obvious they needed to save the selection.