Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(headless-client): deprecate subcommands for now #4953

Merged
merged 35 commits into from
May 13, 2024

Conversation

ReactorScram
Copy link
Collaborator

@ReactorScram ReactorScram commented May 10, 2024

Closes #4907

They're still accepted, but the binary entirely determines the behavior. This makes the code for CLI parsing and token handling simpler with fewer branches, so it's easier to be sure it's correct.

Replaces #4942 which isn't doing what I intended anymore.

I'm going to want a well-known dir that the Windows IPC service writes logs to,
and that the Windows GUI can pick them up from.

I don't know how I did this for Linux last week, but it should probably be in
here too.
This has a known gap where theoretically the GUI could sign in while the
service is hung in startup, and then the service would wipe out the GUI's
DNS rules.

The workaround for that would be to restart the GUI, but in practice I think
this is almost impossible, Windows would have to give the service no CPU time
while the user was signing in, then the user would have to immediately open
Firezone before the service got running.

Closes #4899
They're still accepted, but the binary entirely determines the behavior.
This makes the code for CLI parsing and token handling simpler with
fewer branches, so it's easier to be sure it's correct.
@ReactorScram ReactorScram added the kind/refactor Code refactoring label May 10, 2024
@ReactorScram ReactorScram self-assigned this May 10, 2024
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 3:52pm

Copy link

github-actions bot commented May 10, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented May 10, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 241.8 MiB (+0%) 243.1 MiB (-0%) 363 (-26%)
direct-tcp-server2client 239.7 MiB (-3%) 241.3 MiB (-2%) 349 (+86%)
relayed-tcp-client2server 228.0 MiB (+2%) 229.0 MiB (+2%) 298 (+26%)
relayed-tcp-server2client 239.0 MiB (+2%) 239.7 MiB (+2%) 297 (-29%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.05ms (+27%) 43.52% (+5%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (-37%) 22.66% (+1%)
relayed-udp-client2server 500.0 MiB (-0%) 0.08ms (+49%) 54.69% (-1%)
relayed-udp-server2client 500.0 MiB (+0%) 0.01ms (-50%) 37.08% (-15%)

@ReactorScram ReactorScram marked this pull request as ready for review May 13, 2024 14:28
@ReactorScram ReactorScram requested a review from jamilbk May 13, 2024 14:28
@ReactorScram ReactorScram linked an issue May 13, 2024 that may be closed by this pull request
Base automatically changed from fix/windows-dns-4899 to main May 13, 2024 15:09
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ReactorScram ReactorScram added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit b444dee May 13, 2024
135 checks passed
@ReactorScram ReactorScram deleted the refactor/deprecate-subcommand branch May 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ux(headless-client): remove auto-detected IPC service mode
2 participants