Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix flaky dns-systemd test by waiting a second before running #4962

Merged
merged 1 commit into from
May 13, 2024

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented May 12, 2024

It appears that occasionally the test runs before DNS sentinel is applied and/or Resources updated.

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 12, 2024 4:12pm

@jamilbk jamilbk requested a review from ReactorScram May 12, 2024 15:58
@github-actions github-actions bot added the area/ci Changes to the CI pipeline / Github Actions label May 12, 2024
Copy link

github-actions bot commented May 12, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented May 12, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 241.0 MiB (+1%) 243.3 MiB (+2%) 189 (+22%)
direct-tcp-server2client 243.5 MiB (+1%) 244.9 MiB (+1%) 270 (+18%)
relayed-tcp-client2server 227.2 MiB (+2%) 228.0 MiB (+2%) 200 (-19%)
relayed-tcp-server2client 238.1 MiB (+1%) 238.7 MiB (+1%) 344 (+7%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.03ms (-28%) 44.08% (+9%)
direct-udp-server2client 500.0 MiB (-0%) 0.02ms (+182%) 22.77% (+5%)
relayed-udp-client2server 500.0 MiB (+0%) 0.04ms (+22%) 57.37% (+3%)
relayed-udp-server2client 500.0 MiB (+0%) 0.04ms (-1%) 41.89% (+1%)

Copy link
Collaborator

@ReactorScram ReactorScram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder why, though. If we notify systemd after we've set up the interface and everything, you'd think all other threads on the system should see the interface as set up.

@jamilbk jamilbk added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 469e970 May 13, 2024
135 checks passed
@jamilbk jamilbk deleted the fix/dns-systemd-flaky branch May 13, 2024 14:32
@jamilbk
Copy link
Member Author

jamilbk commented May 13, 2024

LGTM. I wonder why, though. If we notify systemd after we've set up the interface and everything, you'd think all other threads on the system should see the interface as set up.

Maybe it's before the Resource is added? Though I thought that happened in the init message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Changes to the CI pipeline / Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants