Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix docs code blocks with arrow #4982

Merged
merged 1 commit into from
May 14, 2024
Merged

docs: Fix docs code blocks with arrow #4982

merged 1 commit into from
May 14, 2024

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented May 14, 2024 •
edited
Loading

before

Screenshot 2024-05-14 at 6 29 52 AM

after

Screenshot 2024-05-14 at 8 31 40 AM

@vercel Vercel
Copy link

vercel bot commented May 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:31pm

@github-actions github-actions bot added the kind/docs Improvements or updates to documentation label May 14, 2024
@github-actions GitHub Actions
Copy link

Terraform Cloud Plan Output

Plan: 20 to add, 17 to change, 20 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 241.3 MiB (-1%) 243.3 MiB (-1%) 200 (-50%)
direct-tcp-server2client 246.2 MiB (+2%) 247.6 MiB (+2%) 126 (-72%)
relayed-tcp-client2server 227.4 MiB (-3%) 228.2 MiB (-4%) 229 (-9%)
relayed-tcp-server2client 243.7 MiB (+4%) 244.4 MiB (+4%) 396 (+0%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.04ms (+78%) 44.42% (+4%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (+2%) 20.11% (-5%)
relayed-udp-client2server 500.0 MiB (+0%) 0.02ms (-65%) 56.99% (+3%)
relayed-udp-server2client 500.0 MiB (-0%) 0.05ms (+16%) 39.89% (-13%)

@jamilbk jamilbk requested a review from bmanifold May 14, 2024 15:32
@jamilbk jamilbk enabled auto-merge May 14, 2024 15:32
bmanifold
bmanifold approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamilbk jamilbk added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 91babe1 May 14, 2024
135 checks passed
@jamilbk jamilbk deleted the fix/arrow branch May 14, 2024 15:49
jamilbk added a commit that referenced this pull request May 15, 2024
@jamilbk
docs: Fix docs code blocks with arrow (#4982)
a54331a 
before

<img width="222" alt="Screenshot 2024-05-14 at 6 29 52 AM"
src="https://github.com/firezone/firezone/assets/167144/a9308eca-b6ae-417c-a673-94c7ee8cdec6">

after

<img width="209" alt="Screenshot 2024-05-14 at 8 31 40 AM"
src="https://github.com/firezone/firezone/assets/167144/1de92b63-8679-416a-9014-bf3593d141c4">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmanifold bmanifold bmanifold approved these changes

Assignees
No one assigned
Labels
kind/docs Improvements or updates to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamilbk @bmanifold