refactor(portal): Update IDP creation flow #4984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * The new flow for creating an identity provider in Firezone allows the user to not have to worry what features their plan has enabled. It will allow the user to select which identity provider they use and will take them to the appropriate form depending on the features they have enabled on their plan.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output |
Performance Test ResultsTCP
UDP
|
jamilbk
approved these changes
May 14, 2024
There was a problem hiding this comment.
LGTM. Just double-checking -- is there a :help section at the top of each provider's form pointing to the docs for that provider? E.g.
- https://www.firezone.dev/kb/authenticate/google
- https://www.firezone.dev/kb/authenticate/entra
- https://www.firezone.dev/kb/authenticate/okta
I'll refactor those guides to make the sync steps optional as part of #4973
elixir/apps/web/lib/web/live/settings/identity_providers/openid_connect/components.ex
Outdated
Show resolved
Hide resolved
Scratch what I said before, I just checked and there is a help section with a link to the detail docs on each of the providers. |
bmanifold
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 15, 2024
Makes the sync steps optional so the Google, Okta, and Entra guides work for all plans. refs #4984
jamilbk
pushed a commit
that referenced
this pull request
May 15, 2024
Why: * The new flow for creating an identity provider in Firezone allows the user to not have to worry what features their plan has enabled. It will allow the user to select which identity provider they use and will take them to the appropriate form depending on the features they have enabled on their plan. ## Screenshots ### Selecting an identity provider <img width="937" alt="Screenshot 2024-05-14 at 11 53 17 AM" src="https://github.com/firezone/firezone/assets/2646332/31337ad9-13c8-43a2-942c-adb0a951167c"> ### New OIDC form when a custom provider is selected but IDP sync is not enabled for account <img width="903" alt="Screenshot 2024-05-14 at 11 54 58 AM" src="https://github.com/firezone/firezone/assets/2646332/2e18d788-60c3-4fad-b749-351559a24aca">
jamilbk
added a commit
that referenced
this pull request
May 15, 2024
Makes the sync steps optional so the Google, Okta, and Entra guides work for all plans. refs #4984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Screenshots
Selecting an identity provider
New OIDC form when a custom provider is selected but IDP sync is not enabled for account