Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(windows): style the MSI installer #4990

Merged
merged 1 commit into from
May 14, 2024
Merged

chore(windows): style the MSI installer #4990

merged 1 commit into from
May 14, 2024

Conversation

ReactorScram
Copy link
Collaborator

Closes #4919
image
image
image

@vercel Vercel
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) May 14, 2024 11:03pm

@ReactorScram ReactorScram self-assigned this May 14, 2024
@ReactorScram ReactorScram added area/windows_client Issues related to the Windows client kind/UX Changes related specifically to overall user experience and product quality labels May 14, 2024
@ReactorScram ReactorScram requested a review from jamilbk May 14, 2024 23:04
@github-actions GitHub Actions
Copy link

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

@ReactorScram ReactorScram changed the title ux(windows): style the MSI installer chore(windows): style the MSI installer May 14, 2024
@github-actions GitHub Actions
Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 240.5 MiB (-1%) 242.3 MiB (-1%) 274 (+39%)
direct-tcp-server2client 247.3 MiB (+5%) 249.0 MiB (+5%) 256 (-43%)
relayed-tcp-client2server 228.1 MiB (+2%) 228.8 MiB (+2%) 245 (-3%)
relayed-tcp-server2client 238.7 MiB (+0%) 239.1 MiB (-0%) 297 (-14%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.03ms (-95%) 47.02% (+10%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (-6%) 20.46% (-6%)
relayed-udp-client2server 499.9 MiB (-0%) 0.04ms (-20%) 54.30% (-3%)
relayed-udp-server2client 500.0 MiB (+0%) 0.04ms (+50%) 43.13% (+9%)

@ReactorScram ReactorScram marked this pull request as ready for review May 14, 2024 23:14
jamilbk
jamilbk approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ReactorScram ReactorScram added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 43223f2 May 14, 2024
135 checks passed
@ReactorScram ReactorScram deleted the ux/style-msi branch May 14, 2024 23:42
jamilbk pushed a commit that referenced this pull request May 15, 2024
@ReactorScram @jamilbk
chore(windows): style the MSI installer (#4990)
f7509d1 
Closes #4919 

![image](https://github.com/firezone/firezone/assets/13400041/455bd444-3b75-4bfb-8cc0-afdcd29c55de)

![image](https://github.com/firezone/firezone/assets/13400041/b166fb9a-d7bc-4ac8-8ade-99cebfc7b7a5)

![image](https://github.com/firezone/firezone/assets/13400041/27eff651-08a4-4185-93cc-e1e544595ad8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

Assignees

@ReactorScram ReactorScram

Labels
area/windows_client Issues related to the Windows client kind/UX Changes related specifically to overall user experience and product quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ux(windows-client): style MSI installer
2 participants
@ReactorScram @jamilbk