Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove backwards compatibility code for older Docker images #4993

Merged
merged 1 commit into from
May 15, 2024
Merged

test: remove backwards compatibility code for older Docker images #4993

merged 1 commit into from
May 15, 2024

Conversation

ReactorScram
Copy link
Collaborator

Closes #4951

@ReactorScram ReactorScram self-assigned this May 15, 2024
@vercel Vercel
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) May 15, 2024 2:46pm

@github-actions github-actions bot added the kind/test PRs that are focused on increasing test coverage label May 15, 2024
@github-actions GitHub Actions
Copy link

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 239.5 MiB (-1%) 240.8 MiB (-1%) 275 (+12%)
direct-tcp-server2client 238.4 MiB (-0%) 240.2 MiB (-0%) 467 (-10%)
relayed-tcp-client2server 223.9 MiB (-2%) 224.7 MiB (-2%) 245 (+4%)
relayed-tcp-server2client 237.0 MiB (-0%) 237.9 MiB (-1%) 308 (-39%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.03ms (+5%) 43.42% (+8%)
direct-udp-server2client 500.0 MiB (+0%) 0.01ms (-39%) 19.88% (-9%)
relayed-udp-client2server 500.0 MiB (-0%) 0.05ms (+221%) 54.99% (-1%)
relayed-udp-server2client 500.0 MiB (+0%) 0.01ms (-79%) 40.80% (-9%)

@ReactorScram ReactorScram marked this pull request as ready for review May 15, 2024 14:57
@ReactorScram ReactorScram requested a review from jamilbk May 15, 2024 15:01
jamilbk
jamilbk approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReactorScram ReactorScram added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@ReactorScram ReactorScram added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 9c143bc May 15, 2024
135 checks passed
@ReactorScram ReactorScram deleted the refactor/rename-linux-client branch May 15, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

Assignees

@ReactorScram ReactorScram

Labels
kind/test PRs that are focused on increasing test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove backwards compatibility code introduced in #4933
2 participants
@ReactorScram @jamilbk