Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connlib): set_payload is called for udp packets for tests #5018

Merged
merged 1 commit into from
May 17, 2024

Conversation

conectado
Copy link
Collaborator

came up while working on #4994

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) May 16, 2024 11:33pm

@github-actions github-actions bot added the kind/chore Issues related to repository cleanup or maintenance label May 16, 2024
Copy link

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 240.5 MiB (+2%) 241.8 MiB (+2%) 247 (-7%)
direct-tcp-server2client 242.0 MiB (+1%) 243.7 MiB (+1%) 578 (+28%)
relayed-tcp-client2server 222.0 MiB (-1%) 222.8 MiB (-1%) 231 (-13%)
relayed-tcp-server2client 236.9 MiB (+1%) 237.8 MiB (+1%) 454 (+41%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.04ms (+124%) 39.31% (-5%)
direct-udp-server2client 500.0 MiB (+0%) 0.05ms (+228%) 21.98% (+6%)
relayed-udp-client2server 499.7 MiB (-0%) 0.48ms (+1332%) 54.85% (-1%)
relayed-udp-server2client 500.0 MiB (-0%) 0.05ms (+59%) 37.50% (-11%)

Copy link
Collaborator

@ReactorScram ReactorScram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@conectado conectado enabled auto-merge May 16, 2024 23:53
@conectado conectado added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 941b18b May 17, 2024
135 checks passed
@conectado conectado deleted the chore/ensure-payload-is-included-in-udp-packets branch May 17, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Issues related to repository cleanup or maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants