Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ux): Add sync time hint help to idp show #5034

Merged
merged 1 commit into from
May 20, 2024
Merged

chore(ux): Add sync time hint help to idp show #5034

merged 1 commit into from
May 20, 2024

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented May 20, 2024

Adds help text to IdP show page to communicate a little more about how the sync works and also link to the relevant docs.

Fixes #5025

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 3:39am

@jamilbk jamilbk requested a review from bmanifold May 20, 2024 03:38
@github-actions github-actions bot added the kind/chore Issues related to repository cleanup or maintenance label May 20, 2024
Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 240.0 MiB (+1%) 241.5 MiB (+1%) 219 (-23%)
direct-tcp-server2client 241.0 MiB (-0%) 242.7 MiB (-0%) 385 (+43%)
relayed-tcp-client2server 231.5 MiB (+2%) 232.6 MiB (+2%) 237 (-15%)
relayed-tcp-server2client 233.5 MiB (-1%) 234.0 MiB (-2%) 299 (-24%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.03ms (+32%) 42.51% (-0%)
direct-udp-server2client 500.0 MiB (-0%) 0.02ms (-10%) 21.84% (+1%)
relayed-udp-client2server 499.5 MiB (-0%) 0.04ms (+18%) 54.49% (-7%)
relayed-udp-server2client 500.0 MiB (+0%) 0.02ms (-66%) 43.69% (-4%)

Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamilbk jamilbk enabled auto-merge May 20, 2024 04:38
Copy link

Terraform Cloud Plan Output

Plan: 17 to add, 14 to change, 17 to destroy.

Terraform Cloud Plan

@jamilbk jamilbk added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 048a69e May 20, 2024
135 checks passed
@jamilbk jamilbk deleted the ux/sync-time branch May 20, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/chore Issues related to repository cleanup or maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communicate how often sync job runs on average
2 participants