Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(portal): Track page views and sign ups using Mixpanel and HubSpot on public pages #5050

Merged
merged 6 commits into from
May 21, 2024

Conversation

AndrewDryga
Copy link
Collaborator

@AndrewDryga AndrewDryga commented May 20, 2024

Fixes firezone/gtm#253
Fixes firezone/gtm#278

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 2:27am

@github-actions github-actions bot added the kind/feature New feature or request label May 20, 2024
Copy link

github-actions bot commented May 20, 2024

Terraform Cloud Plan Output

Plan: 16 to add, 15 to change, 16 to destroy.

Terraform Cloud Plan

Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about data scrubbing.

var mixpanel = window.mixpanel || null;
if (mixpanel) {
mixpanel.identify(id);
mixpanel.people.set({ $email: email, $name: name });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm can we easily scrub this email and name data from Mixpanel later on? We need to be able to service DSAR requests (or maybe it's not worth tracking it?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamilbk we can delete the profile in Mixpanel. I kept it only so that we can cross-reference customer journeys, we sync it it in HubSpot anyway

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K, I think it's fine. I just need to go update some legal docs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove it If that's a pain. I don't think it's required, just a recommended attribute. We can always use Actor ID and look it up in our database to find the email.

Copy link

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 244.7 MiB (+0%) 246.0 MiB (+0%) 100 (-48%)
direct-tcp-server2client 238.6 MiB (-1%) 240.1 MiB (-1%) 405 (+84%)
relayed-tcp-client2server 235.2 MiB (+3%) 236.1 MiB (+3%) 256 (-3%)
relayed-tcp-server2client 233.9 MiB (-3%) 234.4 MiB (-3%) 331 (-39%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.03ms (+12%) 44.11% (+13%)
direct-udp-server2client 500.0 MiB (-0%) 0.01ms (-64%) 21.96% (+50%)
relayed-udp-client2server 500.0 MiB (-0%) 0.03ms (-39%) 55.11% (-0%)
relayed-udp-server2client 500.0 MiB (-0%) 0.01ms (-15%) 37.21% (-18%)

@AndrewDryga AndrewDryga merged commit a7e5468 into main May 21, 2024
135 checks passed
@AndrewDryga AndrewDryga deleted the andrew/mixpanel branch May 21, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants