-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(portal): Track page views and sign ups using Mixpanel and HubSpot on public pages #5050
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Terraform Cloud Plan Output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question about data scrubbing.
elixir/apps/web/assets/js/hooks.js
Outdated
var mixpanel = window.mixpanel || null; | ||
if (mixpanel) { | ||
mixpanel.identify(id); | ||
mixpanel.people.set({ $email: email, $name: name }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm can we easily scrub this email and name data from Mixpanel later on? We need to be able to service DSAR requests (or maybe it's not worth tracking it?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamilbk we can delete the profile in Mixpanel. I kept it only so that we can cross-reference customer journeys, we sync it it in HubSpot anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K, I think it's fine. I just need to go update some legal docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove it If that's a pain. I don't think it's required, just a recommended attribute. We can always use Actor ID and look it up in our database to find the email.
Performance Test ResultsTCP
UDP
|
Fixes firezone/gtm#253
Fixes firezone/gtm#278