Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gui-client): Bubble up connlib panics as error dialogs in the GUI #5098

Merged
merged 44 commits into from
May 28, 2024
Merged

chore(gui-client): Bubble up connlib panics as error dialogs in the GUI #5098

merged 44 commits into from
May 28, 2024

Conversation

ReactorScram
Copy link
Collaborator

@ReactorScram ReactorScram commented May 22, 2024 •
edited
Loading

Closes #5046

image

@ReactorScram
work towards enabling the debug IPC service on Linux
c6caf88
@ReactorScram
Linux has the debug IPC service now
78d08fc
@ReactorScram
refactor
2f324ed
@ReactorScram
refactor
979d645
@ReactorScram
fix Windows build
3d2cdf0
@ReactorScram
move almost everything out of windows module
8d9e1d5
@ReactorScram
Fix Linux build
ba1a713
@ReactorScram
fix Windows clippy
46a9146
@ReactorScram
hide this comment from the CLI output
b605b46
@ReactorScram
fix Windows service
86092b9
@ReactorScram
Merge branch 'refactor/debug-ipc-service' of github.com:firezone/fire…
a13c3f3 
…zone into refactor/debug-ipc-service
@ReactorScram
checkpoint
c21b906
@ReactorScram
checkpoint
52ea524
@ReactorScram
extract almost all stuff to the platform-independent module
dbafcba
@ReactorScram
de-dupe
92dfb05
@ReactorScram
Merge remote-tracking branch 'origin/main' into refactor/debug-ipc-se…
99bbe9e 
…rvice
@ReactorScram
this only needs to be a type alias, not a wrapper struct
8565d65
@ReactorScram
Merge branch 'refactor/debug-ipc-service' into refactor/dedupe-ipc-cl…
9aa92c9 
…ients
@ReactorScram
Merge remote-tracking branch 'origin/refactor/dedupe-ipc-clients' int…
9c8b3ea 
…o chore/5046-bubble-errors
@ReactorScram
tell the GUI whether it's an auth error
7a5667f
@ReactorScram
show dialog for non-auth errors
1d50c23
@ReactorScram
remove test panic
613dd88
@ReactorScram ReactorScram self-assigned this May 22, 2024
@vercel Vercel
Copy link

vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 3:59pm

@github-actions github-actions bot added the kind/chore Issues related to repository cleanup or maintenance label May 22, 2024
@ReactorScram ReactorScram changed the base branch from main to refactor/dedupe-ipc-clients May 22, 2024 21:38
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

@ReactorScram ReactorScram linked an issue May 22, 2024 that may be closed by this pull request
chore(gui-client): Bubble panics from connlib in the IPC service to error dialogs in the GUI #5046
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 236.2 MiB (-2%) 238.7 MiB (-2%) 413 (+92%)
direct-tcp-server2client 240.8 MiB (-2%) 242.6 MiB (-2%) 50 (-90%)
relayed-tcp-client2server 224.1 MiB (-1%) 225.1 MiB (-1%) 335 (+57%)
relayed-tcp-server2client 235.7 MiB (-0%) 236.3 MiB (-0%) 316 (-21%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.43ms (+649%) 46.33% (+5%)
direct-udp-server2client 500.0 MiB (-0%) 0.02ms (+68%) 20.70% (-12%)
relayed-udp-client2server 500.0 MiB (+0%) 0.03ms (-43%) 56.28% (+0%)
relayed-udp-server2client 500.0 MiB (+0%) 0.03ms (-52%) 37.48% (-13%)

@ReactorScram ReactorScram marked this pull request as ready for review May 22, 2024 22:03
jamilbk
jamilbk approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReactorScram
Merge remote-tracking branch 'origin/main' into refactor/debug-ipc-se…
bfc6ac6 
…rvice
@ReactorScram
use PathBuf here instead of String
f881898
@ReactorScram
remove outdated comment
2a71eff
@ReactorScram
remove unused CLI args
24b9944
@ReactorScram
use futures::future::select to simplify the signal polling
43fac19
@ReactorScram
Merge remote-tracking branch 'origin/main' into refactor/debug-ipc-se…
f55f3d1 
…rvice
@ReactorScram
fix Windows build
e89707f
@ReactorScram
fix incorrect SIGHUP behavior
bd86707
@ReactorScram
fix Linux
c1e7014
@ReactorScram
I forgot to commit this
a82f163
@ReactorScram
Merge remote-tracking branch 'origin/refactor/debug-ipc-service' into…
f61d543 
… refactor/debug-ipc-service
@ReactorScram
fmt
c6b4bba
@ReactorScram
clippy
e85bed6
@ReactorScram
fix IPC service
4ee20d7
@ReactorScram
move this log to the right place
595bed1
@ReactorScram
Merge remote-tracking branch 'origin/refactor/debug-ipc-service' into…
3f7b8b6 
… refactor/dedupe-ipc-clients
@ReactorScram
improve error messages
a245ff0
@ReactorScram
fix Windows
6818f39
@ReactorScram
Merge branch 'refactor/dedupe-ipc-clients' into chore/5046-bubble-errors
cbd8f5a 
Signed-off-by: Reactor Scram <ReactorScram@users.noreply.github.com>
Base automatically changed from refactor/dedupe-ipc-clients to main May 28, 2024 15:24
@ReactorScram ReactorScram added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 6408131 May 28, 2024
135 checks passed
@ReactorScram ReactorScram deleted the chore/5046-bubble-errors branch May 28, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamilbk jamilbk jamilbk approved these changes

Assignees

@ReactorScram ReactorScram

Labels
kind/chore Issues related to repository cleanup or maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(gui-client): Bubble panics from connlib in the IPC service to error dialogs in the GUI
2 participants
@ReactorScram @jamilbk