Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(connlib): shrink "packet not allowed" log #5476

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

thomaseizinger
Copy link
Member

All allowed IPs can be a fair few which clutters the log. Remove the HashSet from the error and also remove the stuttering; the error already says "Packet not allowed".

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview Jun 25, 2024 0:29am

Copy link

github-actions bot commented Jun 21, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 23 to change, 2 to destroy.

Terraform Cloud Plan

Copy link

github-actions bot commented Jun 21, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 230.5 MiB (-2%) 232.6 MiB (-2%) 301 (+32%)
direct-tcp-server2client 236.7 MiB (+0%) 238.0 MiB (-0%) 228 (-66%)
relayed-tcp-client2server 240.4 MiB (+1%) 241.4 MiB (+1%) 386 (+34%)
relayed-tcp-server2client 240.0 MiB (-2%) 241.0 MiB (-1%) 926 (+53%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (+0%) 0.02ms (-87%) 47.70% (+9%)
direct-udp-server2client 500.0 MiB (+0%) 0.03ms (+192%) 19.24% (-13%)
relayed-udp-client2server 500.0 MiB (-0%) 0.05ms (+74%) 52.13% (+0%)
relayed-udp-server2client 500.0 MiB (+0%) 0.01ms (-54%) 32.91% (+4%)

@thomaseizinger thomaseizinger force-pushed the refactor/dns-translation-on-gateway branch from fe6cced to f3e770f Compare June 21, 2024 04:09
@thomaseizinger thomaseizinger force-pushed the chore/connlib/silence-allow-logs branch from 8f809ab to 22dc0af Compare June 21, 2024 04:10
@thomaseizinger thomaseizinger force-pushed the refactor/dns-translation-on-gateway branch from f3e770f to 5e2a885 Compare June 24, 2024 00:14
@thomaseizinger thomaseizinger force-pushed the chore/connlib/silence-allow-logs branch from 22dc0af to f8ed81b Compare June 24, 2024 00:16
Base automatically changed from refactor/dns-translation-on-gateway to main June 24, 2024 23:57
@thomaseizinger thomaseizinger marked this pull request as ready for review June 25, 2024 00:28
@thomaseizinger thomaseizinger added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit eec0652 Jun 25, 2024
156 checks passed
@thomaseizinger thomaseizinger deleted the chore/connlib/silence-allow-logs branch June 25, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants