Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookie encryption salt to session #671

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

conectado
Copy link
Collaborator

Closes firezone/product#365

@conectado conectado requested a review from jamilbk June 1, 2022 14:27
Copy link
Member

@jamilbk jamilbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jamilbk
Copy link
Member

jamilbk commented Jun 1, 2022

@conectado Just double-checking -- did you happen to test local sessions still work fine after enabling this setting? I.e. sign in / sign out. I imagine a user would need to clear cookies once this is rolled out?

@conectado
Copy link
Collaborator Author

@conectado Just double-checking -- did you happen to test local sessions still work fine after enabling this setting? I.e. sign in / sign out. I imagine a user would need to clear cookies once this is rolled out?

I have tested logging in and out and that session is working. But haven't tested what happens after to a pre-existing session when the setting gets enabled. I'll do that now.

@conectado
Copy link
Collaborator Author

@jamilbk seems like after enabling the setting, the old unencrypted cookie gets invalidated and the user is prompted to login again. I think this is the desired behavior. And just in case I tested the other way around, disabling the feature, and it works the same way.

@jamilbk
Copy link
Member

jamilbk commented Jun 1, 2022

Awesome, thanks!

@jamilbk jamilbk merged commit c67d9a8 into firezone:master Jun 1, 2022
@jamilbk jamilbk added the kind/feature New feature or request label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants