Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove http-related nginx config #866

Merged
merged 2 commits into from
Jul 29, 2022
Merged

remove http-related nginx config #866

merged 2 commits into from
Jul 29, 2022

Conversation

conectado
Copy link
Collaborator

Continuing with #864 remove remaining HTTP related config.

@conectado conectado requested a review from jamilbk July 28, 2022 05:00
@coveralls
Copy link

coveralls commented Jul 28, 2022

Pull Request Test Coverage Report for Build 4b1090d24596f0ad72ea39adb517eaa1dda2ead0-PR-866

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 69.081%

Files with Coverage Reduction New Missed Lines %
apps/fz_http/lib/fz_http_web/channels/user_socket.ex 7 0%
Totals Coverage Status
Change from base Build 0c50ac677dd412ccc23880a81c1ecf4d2e1fd3ba: 0.1%
Covered Lines: 992
Relevant Lines: 1436

💛 - Coveralls

@jamilbk
Copy link
Member

jamilbk commented Jul 28, 2022

@conectado Mind if I push up a commit to this PR? I think I want to add some docs/config changes.

@conectado
Copy link
Collaborator Author

@conectado Mind if I push up a commit to this PR? I think I want to add some docs/config changes.

@jamilbk go ahead!

@jamilbk jamilbk merged commit b2e292d into master Jul 29, 2022
@jamilbk jamilbk deleted the remove-nginx-http-config branch July 29, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants