Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go easy on the x-forwarded-for header #877

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Go easy on the x-forwarded-for header #877

merged 1 commit into from
Jul 30, 2022

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented Jul 30, 2022

Fixes #863

Logs the connect_info if there's an issue retrieving a valid IP from connect_info, but doesn't prevent the WebSocket from connecting.

@jamilbk jamilbk added the kind/bug Something isn't working label Jul 30, 2022
@jamilbk jamilbk requested a review from conectado July 30, 2022 00:09
@jamilbk jamilbk self-assigned this Jul 30, 2022
@jamilbk jamilbk mentioned this pull request Jul 30, 2022
Closed
@jamilbk jamilbk merged commit e0e780b into master Jul 30, 2022
@jamilbk jamilbk deleted the allow-websocket-with-blank-ips branch July 30, 2022 00:17
@coveralls
Copy link

Pull Request Test Coverage Report for Build d001f582bea2a85cbd6b38a968e2379e56aafe30-PR-877

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 69.556%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/fz_http/lib/fz_http_web/channels/user_socket.ex 0 4 0.0%
Totals Coverage Status
Change from base Build b2e292d4fd1ede71fab693dc7bb67676d56bde69: -0.1%
Covered Lines: 1003
Relevant Lines: 1442
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conectado conectado Awaiting requested review from conectado

Assignees

@jamilbk jamilbk

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing as not connected to UI even though I am.
2 participants
@jamilbk @coveralls