New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernizing the codebase #150
Comments
On further investigation, it was actually this: -module.exports = com;
+export default com; |
I actually didn't mean to close this. |
This is on hold until I can do a study of all projects that depend on Firmata.js and which also stub the constructor with sinon.js |
A friendly suggestion is that instead of worrying about all the other projects and how they depends on this module, maybe start clean with firmata2.js or something like that, with all the fancy async/await or maybe even write it in typescript or at least provide native typescript support to make testing easier etc..? Others can upgrade later whenever they feel like it? |
This has been completed in 2.0.0 |
I've had some work in progress sitting in a stash for a very long time. I tried it out tonight and of course it needed tons of updating. When I got to changing relevant portions of code from function declarations (constructors) to class definitions, mocha exploded:
Which is the last effing straw for mocha. I'm going to start rewriting all the tests to use nodeunit.
The text was updated successfully, but these errors were encountered: