Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernizing the codebase #150

Closed
rwaldron opened this issue Jan 13, 2017 · 5 comments
Closed

Modernizing the codebase #150

rwaldron opened this issue Jan 13, 2017 · 5 comments
Assignees
Labels

Comments

@rwaldron
Copy link
Collaborator

I've had some work in progress sitting in a stash for a very long time. I tried it out tonight and of course it needed tons of updating. When I got to changing relevant portions of code from function declarations (constructors) to class definitions, mocha exploded:

Running "mochaTest:files" (mochaTest) task
>> Mocha exploded!
>> SyntaxError: Unexpected reserved word

Which is the last effing straw for mocha. I'm going to start rewriting all the tests to use nodeunit.

@rwaldron
Copy link
Collaborator Author

On further investigation, it was actually this:

-module.exports = com;
+export default com;

@rwaldron
Copy link
Collaborator Author

I actually didn't mean to close this.

@rwaldron rwaldron reopened this Jan 16, 2017
@rwaldron
Copy link
Collaborator Author

This is on hold until I can do a study of all projects that depend on Firmata.js and which also stub the constructor with sinon.js

@rwaldron rwaldron self-assigned this Jan 16, 2017
@dtheb
Copy link

dtheb commented Nov 30, 2017

A friendly suggestion is that instead of worrying about all the other projects and how they depends on this module, maybe start clean with firmata2.js or something like that, with all the fancy async/await or maybe even write it in typescript or at least provide native typescript support to make testing easier etc..?

Others can upgrade later whenever they feel like it?

@rwaldron
Copy link
Collaborator Author

This has been completed in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants