Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the crashing issue on listaddressgroupings rpc #1085

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

firstcryptoman
Copy link
Collaborator

No description provided.

Copy link
Contributor

@a-bezrukov a-bezrukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, how does this fix a crash?

@levonpetrosyan93
Copy link
Contributor

@a-bezrukov spend transaction types have no standard inputs so in case of spend we don't need to go inside if, but this call pcoin->tx->IsLelantusJoinSplit() is added out of braces by mistake, me need to move it into braces, HasNoRegularInputs() function checkes it for all spend transactions.

@a-bezrukov a-bezrukov merged commit 635a8fa into master Nov 18, 2021
@a-bezrukov a-bezrukov deleted the listaddressgroupings_fix branch November 18, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants