Add warning messages with sending #1434

levoncrypto · 2024-04-18T17:13:35Z

No description provided.

coderabbitai · 2024-04-18T17:13:44Z

Walkthrough

The recent changes focus on enhancing the handling of anonymous mode and warnings in the SendCoinsDialog and SendCoinsEntry classes, streamlining UI updates, and improving test coverage. These modifications include generating warning messages based on recipient addresses, setting anonymous modes, and removing the SendGoPrivateDialog class. Additionally, various test files have been updated to reflect these changes, ensuring robust validation of the new functionality.

Changes

File(s)	Change Summary
`src/qt/sendcoinsdialog.cpp`	Removed `SendGoPrivateDialog` instance, added warning message logic, updated methods for setting anonymous mode and warnings.
`src/qt/sendcoinsdialog.h`	Removed `SendGoPrivateDialog` class and its methods.
`src/qt/sendcoinsentry.cpp`	Updated `setWarning` to generate dynamic warnings, added `generateWarningText` and `setfAnonymousMode` methods.
`src/qt/sendcoinsentry.h`	Added `setfAnonymousMode`, static `generateWarningText`, initialized `fAnonymousMode` to `false`.
`src/qt/test/test_main.cpp`	Included `test_sendcoinsentry.h`, switched chain parameters to `REGTEST`, added `TestSendCoinsEntry` test, commented out `RPCNestedTests`.
`src/qt/test/test_sendcoinsentry.cpp`	Introduced test for generating warning text scenarios.
`src/qt/test/uritests.cpp`	Updated URI parsing test scheme from `firo://` to `firo:`.

Sequence Diagram(s)

sequenceDiagram
    participant User as User
    participant UiSendDialog as SendCoinsDialog
    participant UiSendEntry as SendCoinsEntry

    User ->> UiSendDialog: Initiate send coins
    UiSendDialog ->> UiSendDialog: Check recipient address
    UiSendDialog ->> UiSendEntry: Set anonymous mode and warning
    UiSendEntry ->> UiSendEntry: Generate warning text
    UiSendEntry -->> UiSendDialog: Return warning text
    UiSendDialog ->> UiSendDialog: Append warning to confirmation dialog
    UiSendDialog -->> User: Show confirmation dialog

Poem

On lines of code and logic's hue,
Anonymous whispers gentle and true,
A coin to send, with warning bright,
Secure transactions through day and night.
Gone is the dialog, cumbersome past,
To seamless flow we turn at last.
🐰🚀 Smooth the UIs, skip the fright.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 3

src/qt/sendcoinsentry.h

src/qt/sendcoinsentry.cpp

coderabbitai

Actionable comments posted: 1

src/qt/sendcoinsentry.cpp

coderabbitai

Actionable comments posted: 2

src/qt/sendcoinsentry.cpp

coderabbitai

Actionable comments posted: 1

src/qt/test/test_sendcoinsentry.cpp

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 466316a and 39d6fbf.

Files selected for processing (1)

src/Makefile.qttest.include (4 hunks)

Additional comments not posted (4)

src/Makefile.qttest.include (4)

11-12: Added new MOC files for sendcoinsentry tests correctly.

21-22: Added new header files for sendcoinsentry tests correctly.

32-32: Correctly added test_sendcoinsentry.cpp to the sources list for compiling the new tests.

49-50: Added multiple libraries to the linker dependencies. Ensure all added libraries are utilized to avoid unnecessary build overhead.

coderabbitai

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

src/qt/sendcoinsentry.cpp (1)

14-14: Consider removing the direct inclusion of wallet headers in UI code.

Directly including wallet headers in UI components can lead to tighter coupling between the UI and the core logic. Consider using signals and slots or other decoupling mechanisms to maintain separation of concerns.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 39d6fbf and 4fc081a.

Files selected for processing (5)

src/qt/sendcoinsentry.cpp (4 hunks)
src/qt/sendcoinsentry.h (2 hunks)
src/qt/test/test_main.cpp (3 hunks)
src/qt/test/test_sendcoinsentry.cpp (1 hunks)
src/qt/test/uritests.cpp (1 hunks)

Additional comments not posted (7)

src/qt/test/test_sendcoinsentry.cpp (1)

3-10: The test cases in testGenerateWarningText are well-implemented and cover various scenarios for address types and anonymity modes.

src/qt/test/test_main.cpp (1)

36-36: The changes to use REGTEST for chain parameters and the addition of TestSendCoinsEntry are appropriate for enhancing test coverage in a controlled environment.

Also applies to: 52-53

src/qt/sendcoinsentry.h (1)

52-54: The addition of setfAnonymousMode and generateWarningText, along with the initialization of fAnonymousMode to false, correctly implements the new functionality and follows good coding practices.

Also applies to: 76-76

src/qt/test/uritests.cpp (1)

54-54: The update to the URI scheme from firo:// to firo: is appropriate and aligns with typical URI formats. The tests correctly validate the functionality of URI parsing.
src/qt/sendcoinsentry.cpp (3)
127-134: Refactor suggestion implemented successfully.

The refactor of the setWarning method to utilize generateWarningText for generating the warning message has been successfully implemented, enhancing modularity and maintainability.

257-260: Proper implementation of the setfAnonymousMode method.

The method setfAnonymousMode has been added to manage the anonymous mode state effectively. This change aligns with the PR's objectives to enhance the handling of warning messages based on the anonymity mode.

136-157: Ensure comprehensive handling of address validation and warning generation.

The generateWarningText method now handles various scenarios based on the address type and anonymity mode. Ensure that all edge cases are covered by unit tests, particularly for new address types or changes in address validation logic.

Verification successful

The generateWarningText function is used in multiple places, and there are unit tests covering various scenarios. However, to ensure comprehensive handling of address validation and warning generation, we need to verify the unit tests and the address validation logic.

The unit tests for the generateWarningText function in test_sendcoinsentry.cpp cover various scenarios, including sending to exchange addresses, transparent addresses, and Spark addresses, both in anonymous and non-anonymous modes. Additionally, the address validation functions validateAddress and validateSparkAddress are used extensively throughout the codebase, ensuring comprehensive validation logic.

The unit tests in test_sendcoinsentry.cpp cover the following scenarios:

Sending to an exchange address.

Sending from a transparent address to another transparent address.

Sending from a transparent address to a Spark address.

Sending from a Spark address to another Spark address.

Sending from a private Spark pool to a transparent address.

The address validation functions are defined in wallet.h and wallet.cpp and are used in various parts of the codebase, including sendcoinsentry.cpp, sendcoinsdialog.cpp, and other relevant files.

Based on the provided context and the results from the shell scripts, it appears that the address validation and warning generation logic is comprehensive and well-tested.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify that all address types are handled correctly in generateWarningText.

# Test: Search for the function usage. Expect: Only occurances of the new signature.
rg --type cpp $'generateWarningText'
Length of output: 2036

Script:
#!/bin/bash
# Description: Verify the unit tests for generateWarningText and check address validation logic.

# Test: Display the unit tests for generateWarningText.
rg --type cpp --context 5 'generateWarningText' src/qt/test/test_sendcoinsentry.cpp

# Test: Check the address validation functions in the main codebase.
rg --type cpp 'validateAddress|validateSparkAddress'
Length of output: 5983

coderabbitai

Actionable comments posted: 2

Outside diff range and nitpick comments (2)

src/qt/sendcoinsdialog.cpp (2)

726-728: Ensure that the use of qApp->processEvents(); does not lead to re-entrancy issues, as it can make the application responsive to other events during its execution.

Line range hint 422-536: Consider refactoring the on_sendButton_clicked method to improve readability and maintainability. The method is quite long and handles multiple scenarios, which could be split into smaller helper functions.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4fc081a and 352a098.

Files selected for processing (3)

src/Makefile.qt.include (1 hunks)
src/qt/sendcoinsdialog.cpp (7 hunks)
src/qt/sendcoinsentry.cpp (4 hunks)

Files skipped from review due to trivial changes (1)

src/Makefile.qt.include

Additional comments not posted (5)

src/qt/sendcoinsentry.cpp (4)
127-134: Refactoring of setWarning method is well-implemented, enhancing readability and maintainability.

258-261: Properly encapsulated the setting of fAnonymousMode. Ensure that this method is called appropriately wherever the mode needs to be set.

86-86: Ensure that fAnonymousMode is properly initialized before use in this context.

14-14: Consider using a more specific include path or verifying that the relative path is correct.

Verification successful

The include path ../wallet/wallet.h in src/qt/sendcoinsentry.cpp is correct as the file src/wallet/wallet.h exists.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the existence of the included wallet header file.

# Test: Check if the wallet header file exists at the specified path.
fd 'wallet.h' src/wallet/
Length of output: 68
src/qt/sendcoinsdialog.cpp (1)

Line range hint 422-536: The implementation of setAnonymizeMode effectively updates the UI and internal state based on the anonymous mode. Good use of UI toggling and balance updates.

src/qt/sendcoinsentry.cpp

src/qt/sendcoinsdialog.cpp

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 352a098 and 3083a90.

Files selected for processing (1)

src/qt/sendcoinsdialog.cpp (7 hunks)

Files skipped from review as they are similar to previous changes (1)

src/qt/sendcoinsdialog.cpp

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3083a90 and 1af3606.

Files selected for processing (1)

src/Makefile.qttest.include (4 hunks)

Additional comments not posted (4)

src/Makefile.qttest.include (4)

11-12: The inclusion of moc_test_sendcoinsentry.cpp in TEST_QT_MOC_CPP ensures that the meta-object compiler processes the new test class SendCoinsEntry. This is necessary for Qt's signal and slot mechanism to function correctly in tests.

21-22: The header file for the new test class SendCoinsEntry has been correctly added to TEST_QT_H. This is required for the test suite to recognize and compile the test class.

32-32: The source file for the SendCoinsEntry tests has been added to qt_test_test_bitcoin_qt_SOURCES. This change is essential to ensure that the test implementation is compiled and linked into the test suite.
[APROVED]

40-40: The addition of the -ltor library to the linker flags in qt_test_test_bitcoin_qt_LDADD is crucial for linking the necessary Tor functionality into the test suite. This ensures that any tests involving network anonymity features are properly supported.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1af3606 and 7b8e28f.

Files selected for processing (1)

src/Makefile.qttest.include (4 hunks)

Files skipped from review as they are similar to previous changes (1)

src/Makefile.qttest.include

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7b8e28f and 326a51d.

Files selected for processing (1)

src/Makefile.qttest.include (4 hunks)

Files skipped from review as they are similar to previous changes (1)

src/Makefile.qttest.include

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 326a51d and 2cabafd.

Files selected for processing (1)

src/Makefile.qttest.include (4 hunks)

Files skipped from review as they are similar to previous changes (1)

src/Makefile.qttest.include

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2cabafd and b5334c3.

Files selected for processing (1)

src/Makefile.qttest.include (4 hunks)

Additional comments not posted (4)

src/Makefile.qttest.include (4)

12-12: The addition of moc_test_sendcoinsentry.cpp to TEST_QT_MOC_CPP is consistent with the standard practice of handling MOC files for new test cases.

22-22: The inclusion of test_sendcoinsentry.h in TEST_QT_H correctly follows the project's conventions for managing test header files.

32-32: Correctly added test_sendcoinsentry.cpp to qt_test_test_bitcoin_qt_SOURCES, ensuring the new test is built and included in the test suite.

49-53: The addition of new libraries like -ltor, LIBBLSSIG_LIBS, LIBSPARK, and BACKTRACE_LIB to qt_test_test_bitcoin_qt_LDADD is noted. Please ensure these libraries are necessary and compatible with the new test functionalities.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b5334c3 and a02ecc5.

Files selected for processing (1)

src/Makefile.qttest.include (4 hunks)

Files skipped from review as they are similar to previous changes (1)

src/Makefile.qttest.include

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a02ecc5 and 9d52133.

Files selected for processing (1)

src/Makefile.qttest.include (4 hunks)

Files skipped from review as they are similar to previous changes (1)

src/Makefile.qttest.include

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9d52133 and 76d696b.

Files selected for processing (12)

src/Makefile.am (1 hunks)
src/Makefile.qt.include (1 hunks)
src/Makefile.qttest.include (4 hunks)
src/qt/forms/sendcoinsentry.ui (1 hunks)
src/qt/sendcoinsdialog.cpp (7 hunks)
src/qt/sendcoinsdialog.h (1 hunks)
src/qt/sendcoinsentry.cpp (4 hunks)
src/qt/sendcoinsentry.h (2 hunks)
src/qt/test/test_main.cpp (3 hunks)
src/qt/test/test_sendcoinsentry.cpp (1 hunks)
src/qt/test/test_sendcoinsentry.h (1 hunks)
src/qt/test/uritests.cpp (1 hunks)

Files skipped from review due to trivial changes (4)

src/Makefile.am
src/qt/forms/sendcoinsentry.ui
src/qt/sendcoinsdialog.h
src/qt/test/test_sendcoinsentry.h

Files skipped from review as they are similar to previous changes (7)

src/Makefile.qt.include
src/Makefile.qttest.include
src/qt/sendcoinsdialog.cpp
src/qt/sendcoinsentry.h
src/qt/test/test_main.cpp
src/qt/test/test_sendcoinsentry.cpp
src/qt/test/uritests.cpp

Additional comments not posted (4)

src/qt/sendcoinsentry.cpp (4)
86-86: Ensure fAnonymousMode is defined before use.

This line uses fAnonymousMode, but there's no prior definition or assignment visible in the provided context. Please verify that fAnonymousMode is properly defined and set before this function call.

127-134: Review the refactoring of setWarning method.

The refactoring suggestion to improve the setWarning method by extracting the warning text generation into a separate method (generateWarningText) has been implemented. This should make the method cleaner and more maintainable.

136-158: Optimize the generateWarningText method by using a mapping for warnings.
[REFACTOR_SUGGESTion]
The current implementation of generateWarningText uses multiple conditional statements, which can be optimized and made more readable by using a map or dictionary to associate conditions with warning messages. This would simplify adding or modifying conditions in the future.
QString SendCoinsEntry::generateWarningText(const QString& address, const bool fAnonymousMode) {
    static const QMap<QPair<QString, bool>, QString> warningMessages = {
        {{ "EX", false }, tr("You are sending Firo to an Exchange Address. Exchange Addresses can only receive funds from a transparent address.")},
        // Add other mappings here
    };

    auto key = qMakePair(address.left(2), fAnonymousMode);
    if (warningMessages.contains(key)) {
        return warningMessages[key];
    }

    return QString();
}
258-261: Validate the new method setfAnonymousMode.

The newly added method setfAnonymousMode correctly sets the fAnonymousMode state. Ensure that this method is called appropriately wherever the anonymous mode needs to be set or updated.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 76d696b and 8dd67ed.

Files selected for processing (1)

src/Makefile.qttest.include (4 hunks)

Files skipped from review as they are similar to previous changes (1)

src/Makefile.qttest.include

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8dd67ed and f72c5a7.

Files selected for processing (2)

src/Makefile.qt.include (1 hunks)
src/qt/sendcoinsdialog.cpp (7 hunks)

Files skipped from review as they are similar to previous changes (2)

src/Makefile.qt.include
src/qt/sendcoinsdialog.cpp

justanwar · 2024-06-17T14:11:59Z

Tested ok, warnings appeared as expected.

coderabbitai

Actionable comments posted: 2

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f72c5a7 and ba95af0.

Files selected for processing (13)

src/Makefile.am (1 hunks)
src/Makefile.qt.include (1 hunks)
src/Makefile.qttest.include (4 hunks)
src/libspark/spend_transaction.cpp (1 hunks)
src/qt/forms/sendcoinsentry.ui (1 hunks)
src/qt/sendcoinsdialog.cpp (7 hunks)
src/qt/sendcoinsdialog.h (1 hunks)
src/qt/sendcoinsentry.cpp (4 hunks)
src/qt/sendcoinsentry.h (2 hunks)
src/qt/test/test_main.cpp (3 hunks)
src/qt/test/test_sendcoinsentry.cpp (1 hunks)
src/qt/test/test_sendcoinsentry.h (1 hunks)
src/qt/test/uritests.cpp (1 hunks)

Files skipped from review as they are similar to previous changes (11)

src/Makefile.am
src/Makefile.qt.include
src/Makefile.qttest.include
src/qt/forms/sendcoinsentry.ui
src/qt/sendcoinsdialog.cpp
src/qt/sendcoinsdialog.h
src/qt/sendcoinsentry.h
src/qt/test/test_main.cpp
src/qt/test/test_sendcoinsentry.cpp
src/qt/test/test_sendcoinsentry.h
src/qt/test/uritests.cpp

Additional comments not posted (4)

src/qt/sendcoinsentry.cpp (4)
127-134: Refactor suggestion to reduce complexity in setWarning was implemented as advised in previous reviews.

This makes the code cleaner and easier to maintain, enhancing both readability and maintainability.

136-157: The implementation of generateWarningText method appears comprehensive, handling various scenarios based on address type and anonymity mode.

It effectively manages different conditions to generate appropriate warning messages. Continue to ensure that all edge cases are covered by unit tests.

257-260: The addition of setfAnonymousMode to manage the anonymous mode state is a good enhancement.

This method provides a clear and direct way to update the anonymity mode, which is crucial for the functionality of warning generation based on the address and mode.

86-86: Ensure the setWarning function call uses the correct parameters.

Verification successful

The setWarning function is defined with a single boolean parameter fAnonymousMode and is used consistently with this parameter throughout the codebase.

src/qt/sendcoinsentry.h: Declares the function with bool fAnonymousMode.

src/qt/sendcoinsentry.cpp: Calls the function with fAnonymousMode.

src/qt/sendcoinsdialog.cpp: Calls the function with fAnonymousMode.

No issues were found with the parameter usage in the setWarning function calls.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify that `setWarning` is called with the correct parameters throughout the codebase.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type python $'setWarning'
Length of output: 60

Script:
#!/bin/bash
# Locate the definition of the setWarning function in C++ files
ast-grep --lang cpp --pattern $'void setWarning($_) { $$$ }'

# Verify the correct usage of setWarning function in C++ files
rg --type cpp 'setWarning'
Length of output: 425

src/qt/sendcoinsentry.cpp

src/libspark/spend_transaction.cpp

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ba95af0 and 1717ced.

Files selected for processing (4)

src/qt/sendcoinsdialog.cpp (7 hunks)
src/qt/sendcoinsdialog.h (1 hunks)
src/qt/sendcoinsentry.cpp (4 hunks)
src/qt/sendcoinsentry.h (2 hunks)

Files skipped from review as they are similar to previous changes (4)

src/qt/sendcoinsdialog.cpp
src/qt/sendcoinsdialog.h
src/qt/sendcoinsentry.cpp
src/qt/sendcoinsentry.h

Add warning messages with sending

bacce7c

coderabbitai bot reviewed Apr 18, 2024

View reviewed changes

src/qt/sendcoinsentry.h Outdated Show resolved Hide resolved

src/qt/sendcoinsentry.h Outdated Show resolved Hide resolved

src/qt/sendcoinsentry.cpp Outdated Show resolved Hide resolved

Add warning messages with sending

ab96bf1

coderabbitai bot reviewed Apr 18, 2024

View reviewed changes

src/qt/sendcoinsentry.cpp Outdated Show resolved Hide resolved

Add warning messages with sending (optimize)

5a2b7e4

coderabbitai bot reviewed Apr 18, 2024

View reviewed changes

src/qt/sendcoinsentry.cpp Show resolved Hide resolved

src/qt/sendcoinsentry.cpp Outdated Show resolved Hide resolved

reubenyap requested a review from levonpetrosyan93 April 21, 2024 10:36

levonpetrosyan93 mentioned this pull request Apr 25, 2024

Fix go private window behavior for exchange address #1426

Closed

erciccione mentioned this pull request Apr 29, 2024

improve warning when sending transparent tx #1436

Closed

QT Tests run

466316a

coderabbitai bot reviewed Apr 29, 2024

View reviewed changes

src/qt/test/test_sendcoinsentry.cpp Outdated Show resolved Hide resolved

Linux build fix

39d6fbf

coderabbitai bot reviewed May 6, 2024

View reviewed changes

QT tests and optimization of the warning messages adding function

4fc081a

coderabbitai bot reviewed Jun 9, 2024

View reviewed changes

coderabbitai bot reviewed Jun 12, 2024

View reviewed changes

src/qt/sendcoinsentry.cpp Outdated Show resolved Hide resolved

src/qt/sendcoinsdialog.cpp Show resolved Hide resolved

coderabbitai bot reviewed Jun 13, 2024

View reviewed changes

coderabbitai bot reviewed Jun 14, 2024

View reviewed changes

levonpetrosyan93 previously approved these changes Jun 14, 2024

View reviewed changes

levoncrypto dismissed levonpetrosyan93’s stale review via a02ecc5 June 14, 2024 18:14

coderabbitai bot reviewed Jun 14, 2024

View reviewed changes

levoncrypto force-pushed the ui_warning_messages branch from 31ef0c7 to f454315 Compare June 14, 2024 19:12

coderabbitai bot reviewed Jun 14, 2024

View reviewed changes

Linking error fixed

8dd67ed

levonpetrosyan93 force-pushed the ui_warning_messages branch from 76d696b to 8dd67ed Compare June 17, 2024 01:06

coderabbitai bot reviewed Jun 17, 2024

View reviewed changes

levonpetrosyan93 previously approved these changes Jun 17, 2024

View reviewed changes

reubenyap added this to the Release 0.14.13.3 milestone Jun 17, 2024

reubenyap requested a review from psolstice June 17, 2024 10:19

psolstice previously approved these changes Jun 18, 2024

View reviewed changes

Merge branch 'master' into ui_warning_messages

ba95af0

levonpetrosyan93 dismissed stale reviews from psolstice and themself via ba95af0 June 18, 2024 11:04

levonpetrosyan93 force-pushed the ui_warning_messages branch from f72c5a7 to ba95af0 Compare June 18, 2024 11:04

levonpetrosyan93 previously approved these changes Jun 18, 2024

View reviewed changes

coderabbitai bot reviewed Jun 18, 2024

View reviewed changes

src/qt/sendcoinsentry.cpp Show resolved Hide resolved

src/libspark/spend_transaction.cpp Show resolved Hide resolved

psolstice previously approved these changes Jun 18, 2024

View reviewed changes

Merge branch 'master' into ui_warning_messages

1717ced

levonpetrosyan93 dismissed stale reviews from psolstice and themself via 1717ced June 18, 2024 16:30

coderabbitai bot reviewed Jun 18, 2024

View reviewed changes

reubenyap merged commit 58dff6c into master Jun 18, 2024
6 checks passed

reubenyap deleted the ui_warning_messages branch June 18, 2024 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add warning messages with sending #1434

Add warning messages with sending #1434

levoncrypto commented Apr 18, 2024 •

edited by coderabbitai bot

coderabbitai bot commented Apr 18, 2024 •

edited

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

justanwar commented Jun 17, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

Add warning messages with sending #1434

Add warning messages with sending #1434

Conversation

levoncrypto commented Apr 18, 2024 • edited by coderabbitai bot

coderabbitai bot commented Apr 18, 2024 • edited

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

justanwar commented Jun 17, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

levoncrypto commented Apr 18, 2024 •

edited by coderabbitai bot

coderabbitai bot commented Apr 18, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)