Transaction large error message change #1438
Conversation
WalkthroughThe recent updates across various components of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Out of diff range and nitpick comments (1)
src/qt/bitcoinstrings.cpp (1)
556-556: Update error message to enhance user guidance.Consider changing "please select less inputs" to "please select fewer inputs" for grammatical correctness.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- src/qt/bitcoinstrings.cpp (1 hunks)
- src/spark/sparkwallet.cpp (2 hunks)
- src/wallet/lelantusjoinsplitbuilder.cpp (1 hunks)
- src/wallet/txbuilder.cpp (1 hunks)
- src/wallet/wallet.cpp (3 hunks)
Files skipped from review due to trivial changes (1)
- src/wallet/wallet.cpp
Additional comments not posted (2)
src/wallet/txbuilder.cpp (1)
227-227: Updated error message provides clearer instructions for users on how to handle transactions exceeding the size limit.src/wallet/lelantusjoinsplitbuilder.cpp (1)
324-324: Updated error message provides clearer instructions for users on how to handle transactions exceeding the size limit.
src/spark/sparkwallet.cpp
Outdated
| @@ -1024,7 +1024,7 @@ bool CSparkWallet::CreateSparkMintTransactions( | |||
| // Limit size | |||
| CTransaction txConst(tx); | |||
| if (GetTransactionWeight(txConst) >= MAX_STANDARD_TX_WEIGHT) { | |||
| strFailReason = _("Transaction too large"); | |||
| strFailReason = _("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"); | |||
There was a problem hiding this comment.
Ensure error message consistency and clarity.
- strFailReason = _("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again");
+ strFailReason = _("This transaction exceeds the transaction size limit of 100 kB. Please select fewer inputs or consolidate your UTXOs before trying to send again.");The error message should maintain grammatical consistency ("fewer" instead of "less" for countable items like inputs) and clarity (adding a period before the suggestion). This change aligns with the updated messages in other parts of the codebase.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| strFailReason = _("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"); | |
| strFailReason = _("This transaction exceeds the transaction size limit of 100 kB. Please select fewer inputs or consolidate your UTXOs before trying to send again."); |
src/spark/sparkwallet.cpp
Outdated
| @@ -1536,7 +1536,7 @@ CWalletTx CSparkWallet::CreateSparkSpendTransaction( | |||
| } | |||
|
|
|||
| if (GetTransactionWeight(tx) >= MAX_NEW_TX_WEIGHT) { | |||
| throw std::runtime_error(_("Transaction too large")); | |||
| throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again")); | |||
There was a problem hiding this comment.
Ensure error message consistency and clarity.
- throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"));
+ throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB. Please select fewer inputs or consolidate your UTXOs before trying to send again."));Similar to the previous comment, this error message should also be updated for grammatical accuracy and consistency with other updated messages in the codebase.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again")); | |
| throw std::runtime_error(_("This transaction exceeds the transaction size limit of 100 kB. Please select fewer inputs or consolidate your UTXOs before trying to send again.")); |
src/qt/bitcoinstrings.cpp
Outdated
| @@ -553,7 +553,7 @@ QT_TRANSLATE_NOOP("firo-core", "Transaction has too long of a mempool chain"), | |||
| QT_TRANSLATE_NOOP("firo-core", "Transaction must have at least one recipient"), | |||
| QT_TRANSLATE_NOOP("firo-core", "Transaction not valid."), | |||
| QT_TRANSLATE_NOOP("firo-core", "Transaction too large for fee policy"), | |||
| QT_TRANSLATE_NOOP("firo-core", "Transaction too large"), | |||
| QT_TRANSLATE_NOOP("firo-core", "This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"), | |||
There was a problem hiding this comment.
I suggest something like
| QT_TRANSLATE_NOOP("firo-core", "This transaction exceeds the transaction size limit of 100 kB, please select less inputs or consolidate your UTXOs before trying to send again"), | |
| QT_TRANSLATE_NOOP("firo-core", "transaction is too large (size limit: 100Kb). Select less inputs or consolidate your UTXOs"), |
to make things clearer for non-technical users
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- src/qt/bitcoinstrings.cpp (1 hunks)
- src/spark/sparkwallet.cpp (2 hunks)
- src/wallet/lelantusjoinsplitbuilder.cpp (1 hunks)
- src/wallet/txbuilder.cpp (1 hunks)
- src/wallet/wallet.cpp (3 hunks)
Files skipped from review as they are similar to previous changes (5)
- src/qt/bitcoinstrings.cpp
- src/spark/sparkwallet.cpp
- src/wallet/lelantusjoinsplitbuilder.cpp
- src/wallet/txbuilder.cpp
- src/wallet/wallet.cpp
* Transaction large error message change * Еditing error message
No description provided.