Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally checking if the Pull Request contains the changes requested #208

Closed
alexanmtz opened this issue Jan 3, 2019 · 2 comments
Closed

Comments

@alexanmtz
Copy link

Great app! I'm using on my project https://gitpay.me for issues like and I was wondering if would be cool feature that would check if the PR contains the changes. In other words, if the commits related to that Pull Request fits with the hidden branch change.

@gr2m
Copy link
Contributor

gr2m commented Jan 3, 2019

That would be a cool experiment! There might be false negatives as sometimes the changes might not be identical but still acceptable to fix the respective issue. But would love to see what you come up with

@alexanmtz
Copy link
Author

@gr2m Actually I found a great tool created by Github that will do that in a really effective and interactive way:
https://github.com/marketplace/github-learning-lab

I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants