Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpError: Empty value for parameter 'number': undefined #213

Closed
jywarren opened this issue Mar 21, 2019 · 4 comments · Fixed by #214
Closed

HttpError: Empty value for parameter 'number': undefined #213

jywarren opened this issue Mar 21, 2019 · 4 comments · Fixed by #214

Comments

@jywarren
Copy link
Contributor

Hello, we got this error today trying to use the bot, sorry to keep showing up with problems! We love this bot dearly! 🤖 ❤️

The branch is https://github.com/publiclab/plots2/tree/first-timers-digest-email

We pulled the logs from https://zeit.co/deployments/first-timers-bot.now.sh/logs

Happy to try to help out if there's somewhere to trace this to!

Thank you!!

2019-03-21T17:37:05.345Z probot:first-timers:publiclab/plots2 getting commit "e0132925784e48f7126a0d419ca5c47d2acc1f25"
2019-03-21T17:37:09.472Z probot:first-timers:publiclab/plots2 found commit "Add full paths to email digest images". Changed file "app/views/subscription_mailer/send_digest.html.erb" Found branchUrl "https://github.com/publiclab/plots2/blob/master/app/views/subscription_mailer/send_digest.html.erb"
2019-03-21T17:37:09.472Z probot:first-timers:publiclab/plots2 creating issue...
2019-03-21T17:37:14.999Z probot:first-timers:publiclab/plots2 HttpError: Empty value for parameter 'number': undefined

We have edited our template since it was working, but nothing looks like it'd cause trouble: https://github.com/publiclab/plots2/pull/5098/files

Our configs: https://github.com/publiclab/plots2/tree/master/.github

Thank you for any help!

@jywarren
Copy link
Contributor Author

Oh goodness, ok it worked just while I was writing this! So, perhaps i can close this although not sure if the error we found was an issue?

@jywarren
Copy link
Contributor Author

publiclab/plots2#5230

@gr2m
Copy link
Contributor

gr2m commented Mar 21, 2019

I’ll setup Sentry for the bot so we catch these errors before you :)

@jywarren
Copy link
Contributor Author

jywarren commented Mar 21, 2019 via email

@gr2m gr2m mentioned this issue Mar 21, 2019
@gr2m gr2m closed this as completed in #214 Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants