Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency updates #9

Merged
merged 17 commits into from
Jan 5, 2018
Merged

Dependency updates #9

merged 17 commits into from
Jan 5, 2018

Conversation

Antonio-Laguna
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 3, 2018 •
edited

Coverage Status

Coverage increased (+1.3%) to 74.194% when pulling 4abee45 on dependency-updates into 50fea14 on master.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited

Coverage Status

Coverage increased (+1.5%) to 74.359% when pulling cab4e8d on dependency-updates into 50fea14 on master.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited

Coverage Status

Coverage increased (+1.6%) to 74.522% when pulling 574901d on dependency-updates into 50fea14 on master.

jgallen23
jgallen23 reviewed Jan 4, 2018
View reviewed changes
css.js
inlinesvg(),
svgo(),
triangle(),
cssnested(),
cssnext({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need to turn off the css next nesting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good flag, wasn't aware

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited

Coverage Status

Coverage increased (+1.6%) to 74.522% when pulling ffaa5ca on dependency-updates into 50fea14 on master.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited

Coverage Status

Coverage increased (+2.6%) to 75.51% when pulling 4068911 on dependency-updates into 50fea14 on master.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited

Coverage Status

Coverage increased (+6.1%) to 79.021% when pulling ef0e019 on dependency-updates into 50fea14 on master.

@coveralls
Copy link

coveralls commented Jan 4, 2018 •
edited

Coverage Status

Coverage increased (+8.9%) to 81.818% when pulling 34a8055 on dependency-updates into 50fea14 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+12.4%) to 85.294% when pulling 818ad20 on dependency-updates into 50fea14 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+12.4%) to 85.294% when pulling 818ad20 on dependency-updates into 50fea14 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+13.9%) to 86.765% when pulling fa1d7c7 on dependency-updates into 50fea14 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+13.9%) to 86.765% when pulling fa1d7c7 on dependency-updates into 50fea14 on master.

@coveralls
Copy link

coveralls commented Jan 5, 2018 •
edited

Coverage Status

Coverage increased (+24.0%) to 96.875% when pulling 0468f5d on dependency-updates into 50fea14 on master.

jgallen23
jgallen23 reviewed Jan 5, 2018
View reviewed changes
css.js
if (postcss.messages) {
postcss.messages.forEach(message => {
messages: (pcss, done) => {
// istanbul ignore next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably add tests for this

@jgallen23 jgallen23 merged commit 11e8fc6 into master Jan 5, 2018
@jgallen23 jgallen23 deleted the dependency-updates branch January 5, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgallen23 jgallen23 jgallen23 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Antonio-Laguna @coveralls @jgallen23 @AlejandroPerezMartin