rate limit #22
Merged
rate limit #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallen23
requested changes
May 31, 2017
test/log.test.js
Outdated
| let invocationCount = 0; | ||
| const logr = new Logr({ | ||
| rateLimit: [ | ||
| { tags: ['tag1', 'tag2'], rate: 1000 } |
There was a problem hiding this comment.
We talked in slack how this won't work
jgallen23
requested changes
May 31, 2017
index.js
Outdated
| @@ -14,13 +14,14 @@ const defaults = { | |||
| reporterDefaults: { | |||
| filter: [], | |||
| exclude: [] | |||
| } | |||
| }, | |||
| rateLimit: {} | |||
There was a problem hiding this comment.
rate limit should be reporter specific
There was a problem hiding this comment.
so move into reporter defaults. also should be a number and maybe a rateLimitBasedOnTags: true
There was a problem hiding this comment.
Maybe we rename rateLimit to throttle: 1000. So it would only log one a second
jgallen23
requested changes
May 31, 2017
index.js
Outdated
| @@ -13,14 +13,15 @@ const defaults = { | |||
| reporters: null, | |||
| reporterDefaults: { | |||
| filter: [], | |||
| throttle: {}, | |||
There was a problem hiding this comment.
lets do two separate options to make it more explicit.
throttle: false, throttleBasedOnTags: false
index.js
Outdated
| exclude: [] | ||
| } | ||
| }, |
index.js
Outdated
| @@ -190,6 +191,17 @@ class Logger { | |||
| if (options.exclude.length !== 0 && intersection(options.exclude, tags).length > 0) { | |||
| return; | |||
| } | |||
| // if throttling was specified then throttle log rate: | |||
| if (Object.keys(options.throttle).length > 0) { | |||
| const tagKey = options.throttle.throttleBasedOnTags ? tags.join('') : 'all'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.