Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async #12

Merged
merged 5 commits into from
Dec 31, 2017
Merged

Async #12

merged 5 commits into from
Dec 31, 2017

Conversation

orthagonal
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 94.203% when pulling 1dc0795 on async into 9cbd341 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 94.203% when pulling 1dc0795 on async into 9cbd341 on master.

jgallen23
jgallen23 requested changes Dec 29, 2017
View reviewed changes
package.json Outdated
@@ -31,6 +31,6 @@
"extends": "firstandthird"
},
"dependencies": {
"async": "^2.1.2"
"mkdirp-promise": "^5.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this being used by lib

@coveralls
Copy link

coveralls commented Dec 29, 2017 •
edited

Coverage Status

Coverage decreased (-0.7%) to 94.203% when pulling fa7505d on async into 9cbd341 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.05%) to 96.923% when pulling 25e3bc5 on async into 9cbd341 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+2.05%) to 96.923% when pulling 25e3bc5 on async into 9cbd341 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.1%) to 100.0% when pulling c39828a on async into 9cbd341 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+5.1%) to 100.0% when pulling c39828a on async into 9cbd341 on master.

@orthagonal orthagonal merged commit b97420c into master Dec 31, 2017
@orthagonal orthagonal deleted the async branch December 31, 2017 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgallen23 jgallen23 jgallen23 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orthagonal @coveralls @jgallen23