Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move project listings to web app #128

Closed
Roshanjossey opened this issue Apr 2, 2017 · 13 comments
Closed

Move project listings to web app #128

Roshanjossey opened this issue Apr 2, 2017 · 13 comments

Comments

@Roshanjossey
Copy link
Member

Project listing might be best kept in web app. There we can have more functionality.

🐞 Problem

Current implementation of project listing is constrained by what markdown can do.

🎯 Goal

If we move this to web app, we can implement more functionality like filtering, better way of showing information etc.

💡 Possible solutions

Move the current project suggestion list to web app.

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 🎉
@Roshanjossey
Copy link
Member Author

I'm thinking about having a card like UI for each projects

image

refer to https://opensource.google.com/projects/list/featured to get an idea about how it should look.

@ChrisWcs
Copy link

Hey I would love to start working on this card component. Looks like we need a title, Icon, short summary and link to the page. I will create a basic card to start and then go from there. I will use googles as an example.

@Roshanjossey
Copy link
Member Author

Awesome @ChrisWcs, I think you have the right idea in terms of how cards should look.

Please submit a PR when you have something. It'd be good to start conversations early on

Thank you for taking this up

@ChrisWcs
Copy link

So I have been working on the cards and I also have build a component that would hold the cards. I have also been working on a search feature based on keywords associated with the projects.

Currently, the cards are functional but need some better styling. I am still learning how to design and work with CSS better. The search feature works by allowing the user to put in a keyword like JavaScript, and then click the enter button to filter. Currently it takes two enter clicks to filter it, I have no idea why... Also I have a JS file that exports an array of objects holding info for each project, This might not be best practice. Please let me know of any suggestions, I have enjoyed working on this and I want to learn more. I will probably put some comments in to help describe the project.

@Roshanjossey
Copy link
Member Author

@ChrisWcs, please submit a PR with your changes. I'd be easier to make reviews and suggestions there where we have more context.

If you wanna make additional changes to that PR, it's simple as pushing to that branch

@sudojoseph
Copy link

Did anything happen here or is this still open?

@ChrisWcs
Copy link

It is still open. I have been busy and not had time to work on.

@ofonimefrancis
Copy link

It would be nice if i can contribute to this. If it is still open i guess

@Roshanjossey
Copy link
Member Author

@opiumated: Yes this is still open

@ofonimefrancis
Copy link

Okay , i'll create a new branch and see what has already been done and how i can improve on it

@Roshanjossey Roshanjossey moved this from ToDo to Doing in Web app Oct 2, 2017
@rahrang
Copy link

rahrang commented Oct 12, 2017

Still open?

@Roshanjossey
Copy link
Member Author

@rahrang: This is done. We need some clean up though. Like removing the listing from readme and pointing users to web app. Would you like to work on that?

@Roshanjossey
Copy link
Member Author

Closing as this is done.

@Roshanjossey Roshanjossey moved this from Doing to Done in Web app Oct 15, 2017
nirinarisantatra pushed a commit to nirinarisantatra/first-contributions that referenced this issue Oct 2, 2018
ewh0 pushed a commit to ewh0/first-contributions that referenced this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants