Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addresses #1616 #1621

Merged
merged 1 commit into from
Nov 5, 2017
Merged

Conversation

mandyreal
Copy link

No description provided.

@Roshanjossey
Copy link
Member

@mandyreal, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?


We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source? 
Also, check out projects with easy issues while you’re there.

@Roshanjossey Roshanjossey merged commit 3881a80 into firstcontributions:master Nov 5, 2017
@mandyreal
Copy link
Author

thanks @Roshanjossey ! it was a great learning experience. the fix looked straightforward, then i had to ensure it didn't break anything by running the react app in my local machine. after the web app started and i saw the change, it felt great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants