New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.nl.md #7352
Update README.nl.md #7352
Conversation
Thank you for making these changes @MJMajoor :vulkan: Could you please do a review on these changes @sudojoseph? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes.
translations/README.nl.md
Outdated
@@ -28,7 +28,7 @@ Open een terminal en voer volgend git commando uit: | |||
``` | |||
git clone "url die je net kopieerde" | |||
``` | |||
Waar "url die je net kopieerde" (zonder aanhalingstekens) de url naar deze repository is. Zie de vorige stappen om de url te vinden. | |||
Waar "url die je net kopieerde" (zonder aanhalingstekens) de url naar (jouw fork van) deze repository is. Zie de vorige stappen om de url te vinden. | |||
|
|||
<img align="right" width="300" src="../assets/copy-to-clipboard.png" alt="copy URL to clipboard" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this alt text has to be translated as well?
translations/README.nl.md
Outdated
@@ -87,13 +89,17 @@ Verstuur nu je pull request. | |||
|
|||
<img style="float: right;" src="../assets/submit-pull-request.png" alt="submit pull request" /> | |||
|
|||
Nu ga ik (de beheerder) al je wijzigingen mergen in de master branch van dit project. Als de veranderingen gemerged zijn, zul je hier een email notificatie over ontvangen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
email notificatie » e-mailnotificatie
translations/README.nl.md
Outdated
``` | ||
Hiermee vertel je git dat er nog een andere versie van dit project bestaat op dit specifieke url punt en dat we het upstream zullen noemen. Eens de wijzigingen gemerged zijn, fetch je de nieuwe versie van mijn repo. | ||
Hiermee vertel je git dat er nog een andere versie van dit project bestaat op dit specifieke url punt en dat we het upstream zullen noemen. Wanneer de wijzigingen gemerged zijn, kun je de nieuwe versie fetchen van mijn repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kun je de nieuwe versie fetchen van mijn repo. » kun je de nieuwe versie ophalen (fetchen) van mijn repo.
Thank you for your review @donroyco 🖖 |
@MJMajoor, could you please make changes to address the review comments? You can make changes by pushing to the same branch in your fork. Feel free to ask if you have any questions We also have a slack team to help/mentor people trying to contribute to open source projects. |
My bad. Was on vacation last week and forgot about it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small change that is required.
Co-Authored-By: MJMajoor <milco.majoor@woodwing.com>
@Roshanjossey You're welcome! |
Minor improvements to Dutch translations.
Updated the "Where to go from here?" section to be more consistent with the English version.