switch to (not updated) progress bar instead of notification #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found one issue while testing, otherwise it's working better than before. |
|
Good catch! I added a try except which now also informs the user that there was an issue and where to find more information. On the downside the traceback would now be masked by the try block if not printed (or logged in our case) explicitly. Please test if it works as expected. |
|
It's working fine for me now. Thanks and good work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #73.
Instead of a notification ("Resolving..") with a fixed 5 s length, the plugin now shows the kodi background progress element. This background progress bar is similar to a notification (not a full screen, non blocking). As we have no progress update from yt-dlp we can not update this gui element with a real progress. On my tested skins this would not matter as a progress bar with 0 % still looks much better than a notification with 5 s which is still visible after the video has started.
But before we merge I would like to have somebody (e.g. GautamMKGarg) to test it.