Feat: In commands such as edit_command_buffer set an environment variable to let the editor config setup custom behaviour

[IndianBoy42]

when using edit_command_buffer to edit the command line, i'd love to set some custom keymaps in the opened neovim. Right now there is no direct way to detect whether neovim was opened as part of this edit_command_buffer.

[krobelus]

perhaps

diff --git a/share/functions/__fish_anyeditor.fish b/share/functions/__fish_anyeditor.fish
index 2385d800e..0af3edbf6 100644
--- a/share/functions/__fish_anyeditor.fish
+++ b/share/functions/__fish_anyeditor.fish
@@ -1,6 +1,8 @@
 function __fish_anyeditor --description "Print a editor to use, or an error message"
     set -l editor
-    if set -q VISUAL
+    if set -q FISH_EDITOR
+        echo $FISH_EDITOR | read -at editor
+    else if set -q VISUAL
         echo $VISUAL | read -at editor
     else if set -q EDITOR
         echo $EDITOR | read -at editor
diff --git a/share/functions/funced.fish b/share/functions/funced.fish
index 5e2be69f8..cabbcba75 100644
--- a/share/functions/funced.fish
+++ b/share/functions/funced.fish
@@ -21,6 +21,8 @@ function funced --description 'Edit function definition'
         set editor fish
     else if set -q _flag_editor
         set editor $_flag_editor
+    else if set -q FISH_EDITOR
+        echo $FISH_EDITOR | read -at editor
     else if set -q VISUAL
         echo $VISUAL | read -at editor
     else if set -q EDITOR

[IndianBoy42]

This would allow us use a different editor for fish editing commands. Which would allow me to pass an argument to the editor. But IMO its not as convenient as setting an environment variable before it is used which I can read in the editor config. To use FISH_EDITOR i'd have to set that in my fish config and add the specific arguments rather than having all behaviour contained inside the nvim editor config.

[krobelus]

bind alt-e 'foo=bar edit_command_buffer' ?