New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API to interact with fish_config #2240
Comments
The I'm not sure shipping something like this turned on in fish by default is a good idea. In particular, it is possible to execute arbitrary code from universal variables, so some consideration should be given to securing the interface. (See #1438 for how this caused problems in the past.) |
@zanchey thanks for pointing that out, i didn't connect the existing code in regards to
|
The existing Python doesn't fully follow the REST model, but it does marshall between universal variables and JSON, so if you wanted to convert the API that might be the way to go - then at least you have one known consumer in the codebase. I'm not sure how AngularJS goes with the full REST experience, so that might be something to get worked out before altering the server side. |
I am closing this issue since there is no compelling use case and the security implications are significant. |
i like the universal scope in fish and do use it quite often. i thought about a way to change the value of a variable from the outside of fish. then i stumbled upon https://github.com/typicode/json-server - while serving a different purpose i like it's simplicity. what'd be wonderful for me to have is using
curl
to interact with a little API reflectingset
. i'd be glad if you'd share your thoughts. regards 💾The text was updated successfully, but these errors were encountered: