Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish breaks dbus? #367

Closed
ridiculousfish opened this issue Oct 26, 2012 · 8 comments
Closed

fish breaks dbus? #367

ridiculousfish opened this issue Oct 26, 2012 · 8 comments
Milestone

Comments

@ridiculousfish
Copy link
Member

Samuel reports:

Hey RD.
Does you fork of fishfish have an issue with dbus? I just tried changing it to my default shell and it completely kills dbus in openSUSE.
otherwise it works fine without.

@ridiculousfish
Copy link
Member Author

My speculation is that dbus assumes the default shell is POSIX compliant (i.e. /bin/sh).

@ridiculousfish
Copy link
Member Author

Looks like this has been known for a long time...see http://marc.info/?l=freedesktop-dbus&m=117323277332615&w=2

@howhow
Copy link

howhow commented Dec 28, 2012

I have the same situation in openSUSE and canNOT make fishfish as my default shell, but can start fishfish in bash after login

@ridiculousfish
Copy link
Member Author

Axel gave them the patch six years ago, but it has yet to be integrated.

This seems pretty terrible, as unsophisticated users may be locked out of their machines. Let's see how hard this would be to hack around in fish.

@ridiculousfish
Copy link
Member Author

Investingating more, I think the patch may not be sufficient. In /etc/X11/xdm/Xsession:

exec -l -a ${cmd} ${shell} -c 'exec "${@}"' - "${@}" ;;

No idea why this is being invoked in the login shell.

Anyways to support this current usage, we would need to:

  1. Support the -c flag to mean "run the following arguments as commands"
  2. Support the $@ (or more precisely, the ${@} variable, at least enough for this use case

@ridiculousfish
Copy link
Member Author

I hacked up fish to support this exec usage when passed to -c, and it allows login on an openSUSE machine (!). This is true even with the dbus hacks disabled. Currently my changes are in the OpenSUSE_Hacks branch.

I'm going to email the dbus mailing list with questions about Axel's patch.

@ridiculousfish
Copy link
Member Author

No reply after a week! The dbus mailing list appears dead.

@ridiculousfish
Copy link
Member Author

I merged my hack - edb973f
Now we should no longer kill OpenSUSE

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants