fish_indent reformatting broke my fishtape tests

[edouard-lopez]

related: jorgebucaran/fishtape#32, swsnr/vscode-fish-ide#6

---

I'm using fish_indent through vscode-fish-ide which reformat test file as follows:

 test "set my_var default value"
-  'default_value' = (
+'default_value' = (
     __pure_set_default my_var 'default_value'
     echo $my_var
-  )
+    )
 end

After formatting my tests fails:

❯ fishtape tests/__pure_set_default.test.fish
TAP version 13
not ok 1 set my_var default valuedefault_value
  ---
    operator: fail
    expected: '= or !='
    received: '= default_value '
  ...
not ok 2 skip setting value if default already existsdefault_value
  ---
    operator: fail
    expected: '= or !='
    received: '= default_value '
  ...

Is it possible to extends fish_indent to support fishtape syntax?

[faho]

There's a bit of a problem here. This isn't valid fishscript.

It looks like

test "inject autoloading in config"
    (
        pure::enable_autoloading >/dev/null
        grep -q 'fish_function_path' $HOME/.config/fish/config.fish
    ) $status -eq 0
end

and turns into

fishtape_test  "inject autoloading in config"    (
        pure::enable_autoloading >/dev/null
        grep -q 'fish_function_path' $HOME/.config/fish/config.fish
    ) $status -eq 0

	or set __fishtape_fails (math $__fishtape_fails + 1);    set __fishtape_count (math $__fishtape_count + 1)
fishtape_restore_globals
	if not teardown;        fishtape_error "teardown fail" status 0 $status;        fishtape_cleanup;        exit 1;    end
	if not setup;        fishtape_error "setup fail" status 0 $status;        fishtape_cleanup;        exit 1;    end

via a rather large awk script.

test already has a specific meaning in fish, and it does not start blocks. These files are not valid fish script, even if their names end in ".fish".

---

Honestly, I'd rather figure out a nicer way to write tests in fish-script than hack something like this, which overloads a rather important fish builtin (which we keyworded for 3.0 - not that it matters for fishtape, because that preprocesses the script using awk).

Our own test harness is probably a bit unwieldy, given that we require a ".in" file that includes the actual script to be run, and a ".out" and ".err" file for its stdout and stderr. We also don't ship it with a fish install, so it's not accessible to users.

[zanchey]

To solve your root issue, save your fishtape scripts with a different extension. They aren't valid fish anyway.