-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fuzzy completions for complete --do-complete
?
#5467
Comments
I think this would break completion scripts that use |
It's still possible to not get any results! The scripts can't
Searching for
Uses like Uses like for which, So that leaves three of the four functions, and any external users. |
Looking at it a bit more closely, all of those functions are for completion, which again means that they want to complete. So I'm enabling this now to see if we get any complaints. |
As mentioned by @foonathan on gitter:
This is because
complete --do-complete
only usesCOMPLETION_REQUEST_DEFAULT
.If we changed
fish-shell/src/builtin_complete.cpp
Line 321 in d7b2576
to
complete(do_complete_param, &comp, COMPLETION_REQUEST_DEFAULT | COMPLETION_REQUEST_FUZZY_MATCH);
It would give fuzzy completions. I believe that would improve the situation in most cases where we currently use it, but if anything is assuming that it's always going to be a prefix (not even a substring) it might break.
Alternatively, we could add another flag that enables fuzzy completions, but it's probably a better default to do them.
The text was updated successfully, but these errors were encountered: