Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dirh output with reversed $dirnext #5477

Merged
merged 1 commit into from
Jan 26, 2019
Merged

fix dirh output with reversed $dirnext #5477

merged 1 commit into from
Jan 26, 2019

Conversation

jakalada
Copy link
Contributor

@jakalada jakalada commented Jan 3, 2019

Description

Before:

The order of the variable $dirnext output by the dirh function is reversed.

$ cd Desktop
$ cd a
$ cd b
$ cd c
$ dirh
 4) /Users/jakalada
 3) /Users/jakalada/Desktop
 2) /Users/jakalada/Desktop/a
 1) /Users/jakalada/Desktop/a/b
    /Users/jakalada/Desktop/a/b/c
$ prevd
$ prevd
$ prevd
$ dirh
 1) /Users/jakalada
    /Users/jakalada/Desktop
 1) /Users/jakalada/Desktop/a/b/c
 2) /Users/jakalada/Desktop/a/b
 3) /Users/jakalada/Desktop/a
$ nextd 3                            # select "3) /Users/jakalada/Desktop/a"
$ dirh
 4) /Users/jakalada
 3) /Users/jakalada/Desktop
 2) /Users/jakalada/Desktop/a
 1) /Users/jakalada/Desktop/a/b
    /Users/jakalada/Desktop/a/b/c    # oops! unexpected.

After:

Fixed.

$ dirh
 1) /Users/jakalada
    /Users/jakalada/Desktop
 1) /Users/jakalada/Desktop/a
 2) /Users/jakalada/Desktop/a/b
 3) /Users/jakalada/Desktop/a/b/c
$ nextd 3                             # select "3) /Users/jakalada/Desktop/a/b/c"
$ dirh
 4) /Users/jakalada
 3) /Users/jakalada/Desktop
 2) /Users/jakalada/Desktop/a
 1) /Users/jakalada/Desktop/a/b
    /Users/jakalada/Desktop/a/b/c     # expected!

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

@zanchey
Copy link
Member

zanchey commented Jan 10, 2019

Isn't this working as intended - showing least-to-most recent, rather than a stack?

@jakalada
Copy link
Contributor Author

nextd has a parameter for specifying the path by number, but it is not working properly.

I added description.

Before:

$ dirh
 1) /Users/jakalada
    /Users/jakalada/Desktop
 1) /Users/jakalada/Desktop/a/b/c
 2) /Users/jakalada/Desktop/a/b
 3) /Users/jakalada/Desktop/a
$ nextd 3                            # select "3) /Users/jakalada/Desktop/a"
$ dirh
 4) /Users/jakalada
 3) /Users/jakalada/Desktop
 2) /Users/jakalada/Desktop/a
 1) /Users/jakalada/Desktop/a/b
    /Users/jakalada/Desktop/a/b/c    # oops! unexpected.

After:

$ dirh
 1) /Users/jakalada
    /Users/jakalada/Desktop
 1) /Users/jakalada/Desktop/a
 2) /Users/jakalada/Desktop/a/b
 3) /Users/jakalada/Desktop/a/b/c
$ nextd 3                             # select "3) /Users/jakalada/Desktop/a/b/c"
$ dirh
 4) /Users/jakalada
 3) /Users/jakalada/Desktop
 2) /Users/jakalada/Desktop/a
 1) /Users/jakalada/Desktop/a/b
    /Users/jakalada/Desktop/a/b/c     # expected!

As it is a display problem, I felt it appropriate to fix dirh.

@faho faho merged commit 5c689bb into fish-shell:master Jan 26, 2019
@faho
Copy link
Member

faho commented Jan 26, 2019

Merged, thanks!

@faho faho added the bug Something that's not working as intended label Jan 26, 2019
@faho faho added this to the fish 3.1.0 milestone Jan 26, 2019
@jakalada jakalada deleted the fix-dirh-nextdir-output branch January 26, 2019 15:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something that's not working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants